[WIP] Add time histories #104
Conversation
No validation yet
With existing RCM files
Remove it after we release PyKED 0.4
Includes stroke, clearance, and compression ratio. Move compressed_pressure, compressed_temperature, and compression_time to rcm-data field. Work on #91
|
Was this expected to fail (if still in progress), or no? |
|
It's a flake8 failure, so I'd say, yes because WIP, but not expected 😄 |
pyked/tests/testfile_rcm2.yaml
Outdated
| clearance: | ||
| - 2.5 cm | ||
| compression-ratio: | ||
| - '12.0' |
There was a problem hiding this comment.
are the quote marks needed here?
There was a problem hiding this comment.
Ah, no, shouldn't be, I was testing a weird failure mode. Thanks for the catch
pyked/validation.py
Outdated
| def _validate_isvalid_quantity(self, isvalid_quantity, field, value): | ||
| """Checks for valid given value and appropriate units. | ||
|
|
||
| Args: | ||
| isvalid_quantity (`bool`): flag from schema indicating quantity to be checked. | ||
| field (`str`): property associated with quantity in question. | ||
| value (`str`): string of the value of the quantity | ||
| value (`list`): list with the first element a string of value with units |
There was a problem hiding this comment.
This doesn't read correctly to me: list with the first element a string of value with units
There was a problem hiding this comment.
Oh yeah, that's really bad grammar hah
These properties are necessary to reconstruct a volume trace from a pressure trace in an RCM experiment.
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 878 951 +73
Branches 212 228 +16
=====================================
+ Hits 878 951 +73
Continue to review full report at Codecov.
|
|
Once the tests pass, this should be good to merge 👍 |
CHANGELOG.mdChanges proposed in this pull request:
time-historiesfield to encapsulate all of the time-varying properties of an experiment, including pressure, temperature, volume, absorption, emission, and piston position@pr-omethe-us/chemked