Refactor IBMCLOUD_API_KEY references

[manju956]

Addresses the git issue #666

[ppc64le-cloud-bot]

Welcome @manju956! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉

[ppc64le-cloud-bot]

Hi @manju956. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mkumatag]

/ok-to-test

[kishen-v]

Hope we're good to make this change before we completely deprecate IBMCLOUD_API_KEY

[manju956]

Yes good to make this change.

[kishen-v]

cc: @mkumatag.
I hope it's alright to switch to using IBMCLOUD_APIKEY is okay for make test command.
Right now, we have an error that points to theIBMCLOUD_APIKEY variable not set:

  IBMCLOUD_APIKEY must be set before running "make test"
  Expected
      <string>:
  not to be empty

[kishen-v]

/lgtm

Thanks @manju956 for the changes. :)

[mkumatag]

/lgtm

[ppc64le-cloud-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manju956, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment