Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove k8s.io/apimachinery dependency for wait mechanism #617

Merged
merged 1 commit into from
May 27, 2024

Conversation

kishen-v
Copy link
Contributor

Fixes: #615

Output:

Kishens-MacBook-Pro: bin : remove-k8s-dep  : ./pvsadm image import --pvs-instance-id foo --object rhel-94-04242024.ova.gz -b foo -r us-south --accesskey foo --secretkey foo --pvs-image-name rhel-94-04242024-tier1 --pvs-storagetype tier1 -w -v4
I0519 23:03:21.618637   79792 root.go:50] Using an API key from IBMCLOUD_API_KEY environment variable
I0519 23:03:23.513579   79792 import.go:184] Importing image rhel-94-04242024-tier1. Please wait...
I0519 23:05:29.652725   79792 import.go:211] Image import is in-progress, current state: running
I0519 23:07:29.461965   79792 import.go:211] Image import is in-progress, current state: running
I0519 23:09:29.514869   79792 import.go:211] Image import is in-progress, current state: running
I0519 23:11:29.460364   79792 import.go:211] Image import is in-progress, current state: running
I0519 23:13:29.318834   79792 import.go:205] Image imported successfully in 10m1.046710302s
I0519 23:13:29.319017   79792 import.go:216] Retrieving image details
I0519 23:13:29.937600   79792 import.go:229] Waiting for image rhel-94-04242024-tier1 to be active. Please wait...
I0519 23:15:29.675209   79792 import.go:246] Successfully imported the image: rhel-94-04242024-tier1 with ID: foo in 10.040292425s

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 19, 2024
@kishen-v kishen-v force-pushed the remove-k8s-dep branch 2 times, most recently from c310fc0 to 29fe034 Compare May 27, 2024 10:56
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit f16821a into ppc64le-cloud:main May 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency of k8s.io/apimachinery
3 participants