Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OLF boolean parameters getters #962

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Jan 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

some OLF boolean parameters getters are in the form hasXxxxx(), and are missed in JSON serialization.

What is the new behavior (if this is a feature change)?
all OLF boolean parameters getters are in the form isXxxxx(), and are properly handled in JSON serialization.

Does this PR introduce a breaking change or deprecate an API?

  • Yes

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
    The breaking Change label is missing in OLF :(
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

  • hasVoltageRemoteControl() becomes isVoltageRemoteControl()
  • hasGeneratorReactivePowerRemoteControl() becomes isGeneratorReactivePowerRemoteControl()

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Copy link

@annetill annetill merged commit 1f8fda1 into main Jan 22, 2024
6 checks passed
@annetill annetill deleted the fix-olf-boolean-params-getters branch January 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants