Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator reference priorities #899

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Nov 16, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Angle reference bus is always the (first) slack bus.

What is the new behavior (if this is a feature change)?
Leverage powsybl/powsybl-core#2763

  • Only for generator terminals as a first step
  • Only in LoadFlow, not used in SA nor sensi
  • new OLF parameters:
    • referenceBusSelectionMode with possible values
      • FIRST_SLACK (default, =current behavior): angle reference bus selected as the first slack bus among potentially multiple slacks
      • GENERATOR_REFERENCE_PRIORITY: angle reference bus selected from generator reference priorities
    • writeReferenceTerminals boolean to have reference generator(s) terminals written to the ReferenceTerminals iIDM extension

Does this PR introduce a breaking change or deprecate an API?
No

Other information:

@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from 5e10c67 to d5dfd4d Compare November 16, 2023 10:40
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from d5dfd4d to a62eb31 Compare November 29, 2023 20:59
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from a62eb31 to 7df72d3 Compare December 7, 2023 09:03
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from 7df72d3 to f7b585b Compare January 2, 2024 12:56
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from f7b585b to e26ff9b Compare January 17, 2024 09:51
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch 2 times, most recently from 858d9e7 to d9170d6 Compare January 18, 2024 15:40
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged force-pushed the generator_reference_priorities branch from d9170d6 to 29d5795 Compare January 18, 2024 15:52
@jeandemanged jeandemanged changed the title [WIP] Generator reference priorities Generator reference priorities Jan 18, 2024
@annetill annetill requested review from geofjamg and annetill January 22, 2024 07:46
jeandemanged and others added 3 commits January 22, 2024 08:55
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java
#	src/main/java/com/powsybl/openloadflow/network/LfNetworkStateUpdateParameters.java
#	src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java
#	src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java
#	src/test/java/com/powsybl/openloadflow/ac/NonImpedantBranchWithBreakerIssueTest.java
Copy link

Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeandemanged we can see in your PR that this feature is implemented for generators. It would be feasible to do it also for any injections and busbar sections but very hard for branches and probably useless. Why not in that case, restrict IIDM extension ReferencePriority and ReferenceTerminal to only terminal types that we want to support?

@jeandemanged jeandemanged merged commit 42ddb08 into main Jan 22, 2024
6 checks passed
@jeandemanged jeandemanged deleted the generator_reference_priorities branch January 22, 2024 12:03
@jeandemanged
Copy link
Member Author

@jeandemanged we can see in your PR that this feature is implemented for generators. It would be feasible to do it also for any injections and busbar sections but very hard for branches and probably useless. Why not in that case, restrict IIDM extension ReferencePriority and ReferenceTerminal to only terminal types that we want to support?

Fully agree, we can indeed restrict in core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants