-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator reference priorities #899
Conversation
5e10c67
to
d5dfd4d
Compare
d5dfd4d
to
a62eb31
Compare
a62eb31
to
7df72d3
Compare
7df72d3
to
f7b585b
Compare
f7b585b
to
e26ff9b
Compare
858d9e7
to
d9170d6
Compare
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
d9170d6
to
29d5795
Compare
# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/main/java/com/powsybl/openloadflow/network/LfNetworkStateUpdateParameters.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowProviderTest.java # src/test/java/com/powsybl/openloadflow/ac/NonImpedantBranchWithBreakerIssueTest.java
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeandemanged we can see in your PR that this feature is implemented for generators. It would be feasible to do it also for any injections and busbar sections but very hard for branches and probably useless. Why not in that case, restrict IIDM extension ReferencePriority
and ReferenceTerminal
to only terminal types that we want to support?
Fully agree, we can indeed restrict in core |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Angle reference bus is always the (first) slack bus.
What is the new behavior (if this is a feature change)?
Leverage powsybl/powsybl-core#2763
referenceBusSelectionMode
with possible valuesFIRST_SLACK
(default, =current behavior): angle reference bus selected as the first slack bus among potentially multiple slacksGENERATOR_REFERENCE_PRIORITY
: angle reference bus selected from generator reference prioritieswriteReferenceTerminals
boolean to have reference generator(s) terminals written to the ReferenceTerminals iIDM extensionDoes this PR introduce a breaking change or deprecate an API?
No
Other information: