Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Sort voltage levels input #89

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Sort voltage levels input #89

merged 3 commits into from
Sep 15, 2022

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Sep 15, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
The voltage levels are not always in the same order, as some implementations of network.getVoltageLevelStream() are not

What is the new behavior (if this is a feature change)?
Ensures the voltage levels are always in the same order by sorting them by id

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from geofjamg September 15, 2022 08:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 35f4a8f into main Sep 15, 2022
@flo-dup flo-dup deleted the sort_input branch September 15, 2022 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants