Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xnec provider with powsybl core contingency #165

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

sharyalZ
Copy link
Member

@sharyalZ sharyalZ commented Oct 2, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

This PR adds support for creating XnecProvider with native PowSyBl Contingency types, enabling the flow decomposition module to run with the PowSyBl Contingency types. Previously, only the Branch Contingency type was supported. Unit tests and a minor documentation update are included.

What is the current behavior?

Currently, an XnecProvider object can only be created using PowSyBl Branch Contingency. If IDs of network components other than branches are provided, an error occurs during flow decomposition when applying the contingency. As a result, flow decomposition cannot be performed with all PowSyBl Contingency types.

What is the new behavior (if this is a feature change)?
The proposed changes allow an XnecProvider object to be created by directly adding PowSyBl Contingency object. This enables flow decomposition to be performed with all PowSyBl Contingency types.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@sharyalZ sharyalZ force-pushed the xnec_provider_with_powsybl_contingency branch from 7ba987c to 2f51999 Compare October 2, 2024 16:38
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
@sharyalZ sharyalZ changed the title Xnec provide with powsybl contingency modifications and unit tests Xnec provider with powsybl core contingency Oct 7, 2024
@sharyalZ sharyalZ requested a review from obrix October 7, 2024 17:28
Copy link
Contributor

@OpenSuze OpenSuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted feature !
Thank you for this PR !
I only have a small documentation improvement suggestion

Copy link
Member

@obrix obrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks!

Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
Copy link

sonarqubecloud bot commented Oct 8, 2024

@sharyalZ
Copy link
Member Author

sharyalZ commented Oct 8, 2024

Thanks for the reviews @OpenSuze, @obrix ! :)

@sharyalZ sharyalZ removed the request for review from caioluke October 8, 2024 15:14
@phiedw phiedw merged commit c24ca22 into main Oct 8, 2024
7 checks passed
@phiedw phiedw deleted the xnec_provider_with_powsybl_contingency branch October 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants