-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xnec provider with powsybl core contingency #165
Conversation
7ba987c
to
2f51999
Compare
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
2f51999
to
d754bd5
Compare
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted feature !
Thank you for this PR !
I only have a small documentation improvement suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thanks!
Signed-off-by: Sharyal Zafar <sharyal.zafar@artelys.com>
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
This PR adds support for creating XnecProvider with native PowSyBl Contingency types, enabling the flow decomposition module to run with the PowSyBl Contingency types. Previously, only the Branch Contingency type was supported. Unit tests and a minor documentation update are included.
What is the current behavior?
Currently, an XnecProvider object can only be created using PowSyBl Branch Contingency. If IDs of network components other than branches are provided, an error occurs during flow decomposition when applying the contingency. As a result, flow decomposition cannot be performed with all PowSyBl Contingency types.
What is the new behavior (if this is a feature change)?
The proposed changes allow an XnecProvider object to be created by directly adding PowSyBl Contingency object. This enables flow decomposition to be performed with all PowSyBl Contingency types.
Does this PR introduce a breaking change or deprecate an API?