Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Network used for default model by Default #252

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jun 14, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #242

@Lisrte Lisrte self-assigned this Jun 14, 2023
Base automatically changed from rename_svc to main June 21, 2023 12:25
@Lisrte Lisrte force-pushed the rename_network_to_default branch from 7d95690 to 87131b5 Compare June 21, 2023 13:46
Lisrte added 4 commits June 21, 2023 16:09
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java
#	dynawaltz/src/test/resources/disconnect_hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/disconnect_hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/grid_forming_converter_dyd.xml
#	dynawaltz/src/test/resources/hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dyd.xml
#	dynawaltz/src/test/resources/svarc_dyd.xml
#	dynawaltz/src/test/resources/wecc_pv_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_synchro_dyd.xml

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/svarcs/DefaultStaticVarCompensatorModel.java
#	dynawaltz/src/test/resources/disconnect_hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/disconnect_hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/grid_forming_converter_dyd.xml
#	dynawaltz/src/test/resources/hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dyd.xml
#	dynawaltz/src/test/resources/svarc_dyd.xml
#	dynawaltz/src/test/resources/wecc_pv_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_synchro_dyd.xml

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte force-pushed the rename_network_to_default branch from 3aeda8d to 638c6a8 Compare June 21, 2023 14:10
Lisrte added 2 commits June 21, 2023 16:31
# Conflicts:
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/DynaWaltzContext.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/svarcs/DefaultStaticVarCompensatorModel.java
#	dynawaltz/src/test/resources/disconnect_hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/disconnect_hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/grid_forming_converter_dyd.xml
#	dynawaltz/src/test/resources/hvdc_pv_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dangling_dyd.xml
#	dynawaltz/src/test/resources/hvdc_vsc_dyd.xml
#	dynawaltz/src/test/resources/svarc_dyd.xml
#	dynawaltz/src/test/resources/wecc_pv_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_dyd.xml
#	dynawaltz/src/test/resources/wecc_wt_synchro_dyd.xml
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.1% 95.1% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 85d6d14 into main Jun 21, 2023
@geofjamg geofjamg deleted the rename_network_to_default branch June 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The suffix Network should be remove and use Default instead
3 participants