-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter in NetworkSerDe.copy to choose between formats (xml, binary, etc.) #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
flo-dup
requested changes
Sep 23, 2024
iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/NetworkSerDe.java
Outdated
Show resolved
Hide resolved
iidm/iidm-serde/src/test/java/com/powsybl/iidm/serde/NetworkSerDeTest.java
Outdated
Show resolved
Hide resolved
…pected, Path actual) Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
flo-dup
reviewed
Sep 23, 2024
iidm/iidm-serde/src/main/java/com/powsybl/iidm/serde/NetworkSerDe.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
…es' into nro/make_network_copy_use_binaries
flo-dup
approved these changes
Sep 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
NetworkSerDe.copy
currently uses XML format to import/export the network.What is the new behavior (if this is a feature change)?
A new
NetworkSerDe.copy
taking an additional parameter is introduced. This new parameterTreeDataFormat format
allows to specify the format to import/export the network.Using the new parameter with
TreeDataFormat.JSON
orTreeDataFormat.BIN
as a value, it takes less time to copy network of various sizes:The copy is now performed by default using the JSON format. (The binary format, which is the most performant, is not yet used because it is still a beta feature.)
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: