Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case date handling when merging networks #2845

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add case date handling when merging networks #2845

merged 1 commit into from
Jan 9, 2024

Conversation

schwitzguebel
Copy link
Contributor

@schwitzguebel schwitzguebel commented Jan 5, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

add case date handling when merging networks
2e829ba 
Signed-off-by: SCHWITZGUEBEL Marc Ext <schwitzguebelmar@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@schwitzguebel schwitzguebel requested a review from geofjamg January 8, 2024 10:21
@annetill annetill requested review from rcourtier and removed request for geofjamg January 9, 2024 09:00
@annetill annetill changed the title add case date handling when merging networks Add case date handling when merging networks Jan 9, 2024
rcourtier
rcourtier approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@rcourtier rcourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Now the merged network has the date of the subnetworks that are merged if they all have the same case date.

@annetill annetill merged commit de1e4f8 into main Jan 9, 2024
6 checks passed
@annetill annetill deleted the set-merged-network-case-date branch January 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murgeyseb murgeyseb murgeyseb approved these changes

@rcourtier rcourtier rcourtier approved these changes

Assignees
No one assigned
Labels
January release PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schwitzguebel @murgeyseb @rcourtier @annetill