Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES import: import TATL shortName or name, not ID + CGMES export: fix on LoadingLimitType and LoadingLimit names #2537

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Apr 11, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix/enhancement on limits naming during CGMES import/export

Does this PR introduce a breaking change or deprecate an API?

No

Other information:

CGMES export: fix on LoadingLimitType and LoadingLimit names

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd added the CGMES label Apr 11, 2023
@miovd miovd requested review from zamarrenolm and marcosmc April 11, 2023 08:47
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must find a way to keep original ids (with alias) in order to export a CGMES file that comes from a CGMES file. It seems that there are lost.

@miovd
Copy link
Contributor Author

miovd commented Apr 12, 2023

You must find a way to keep original ids (with alias) in order to export a CGMES file that comes from a CGMES file. It seems that there are lost.

There were already lost but it does not seem to me that they are supposed to be persistent (same thing for OperationalLimitSet). It was not really useful for me in this case to keep the IDs.

@zamarrenolm
Copy link
Member

You must find a way to keep original ids (with alias) in order to export a CGMES file that comes from a CGMES file. It seems that there are lost.

There were already lost but it does not seem to me that they are supposed to be persistent (same thing for OperationalLimitSet). It was not really useful for me in this case to keep the IDs.

Agree on moving the persistence of identifiers related to operational limits out of this PR. If required, it should be done in a separate one.

@miovd miovd requested a review from annetill April 14, 2023 13:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit db74db1 into main Apr 17, 2023
@miovd miovd deleted the cgmes_limits branch April 17, 2023 08:24
colinepiloquet pushed a commit that referenced this pull request Apr 26, 2023
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet pushed a commit that referenced this pull request Apr 26, 2023
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants