-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGMES import: import TATL shortName or name, not ID + CGMES export: fix on LoadingLimitType and LoadingLimit names #2537
Conversation
CGMES export: fix on LoadingLimitType and LoadingLimit names Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must find a way to keep original ids (with alias) in order to export a CGMES file that comes from a CGMES file. It seems that there are lost.
There were already lost but it does not seem to me that they are supposed to be persistent (same thing for OperationalLimitSet). It was not really useful for me in this case to keep the IDs. |
Agree on moving the persistence of identifiers related to operational limits out of this PR. If required, it should be done in a separate one. |
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix/enhancement on limits naming during CGMES import/export
Does this PR introduce a breaking change or deprecate an API?
No
Other information: