Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSSE Two-Terminal DC line data: allow negative value for SETVL (desired inverter power) #2530

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

marqueslanauja
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

Only SETVL positive values are expected.

What is the new behavior (if this is a feature change)?
Positive and negative values are considered. When the value is positive refers to the desired power at the rectifier and a negative value specifies desired inverter power. The absolute value is set to the power setpoint of the DC link.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@zamarrenolm zamarrenolm changed the title TwoTerminalDc: Support negative setvl (Inverter power) Two-Terminal DC line data: allow negative value for SETVL (desired inverter power) Apr 5, 2023
@zamarrenolm zamarrenolm changed the title Two-Terminal DC line data: allow negative value for SETVL (desired inverter power) PSSE Two-Terminal DC line data: allow negative value for SETVL (desired inverter power) Apr 5, 2023
@zamarrenolm zamarrenolm marked this pull request as ready for review April 6, 2023 15:48
@zamarrenolm zamarrenolm requested a review from geofjamg April 6, 2023 15:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit b279e6a into main Apr 9, 2023
@geofjamg geofjamg deleted the psse_twoTerminalDC_negative_setvl branch April 9, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants