Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES EQ export fixes #2528

Merged
merged 9 commits into from
Apr 13, 2023
Merged

CGMES EQ export fixes #2528

merged 9 commits into from
Apr 13, 2023

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Apr 3, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes

  • RatioTapChanger.tculControlMode value is written as a rdf:resource
  • Add SynchronousMachine.type attribute
  • LinearShuntCompensator.gPerSection is not optional
  • Add WindGeneratingUnit.windGenUnitType attribute
  • Fix stepVoltageIncrement to not be infinite

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
No

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title Fix tculControlMode in CGMES export: it is a reference and not a field [WIP] CGMES export fixes Apr 4, 2023
miovd added 3 commits April 4, 2023 14:03
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title [WIP] CGMES export fixes [WIP] CGMES EQ export fixes Apr 4, 2023
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@miovd miovd changed the title [WIP] CGMES EQ export fixes CGMES EQ export fixes Apr 4, 2023
miovd added 2 commits April 13, 2023 13:57
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 798ac92 into main Apr 13, 2023
@miovd miovd deleted the fix_tculControlMode branch April 13, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants