Security Analysis Result : component count, loss of load/generation/elements #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annetill
reviewed
Dec 13, 2022
.../security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisResultBuilder.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Dec 13, 2022
.../security-analysis-api/src/main/java/com/powsybl/security/SecurityAnalysisResultBuilder.java
Outdated
Show resolved
Hide resolved
2c3bc04 to
7ff37d0
Compare
annetill
reviewed
Jan 6, 2023
|
|
||
| private final Set<String> lostElements; | ||
|
|
||
| public ConnectivityResult(int createdSynchronousComponentCount, int createdConnectedComponentCount, double loadActivePowerLoss, |
There was a problem hiding this comment.
As discuss in TSC yesterday, it seems that the naming is not the good one.
loadActivePowerLosscan be understand as network losses. We suggestdisconnectedLoadActivePower.generationActivePowerLoss: we suggestdisconnectedGenerationActivePower.
There was a problem hiding this comment.
I renamed the two attributes.
…n and set of element lost to post contingency result. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
… keep partial constructors partial. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
…ower and disconnectedGenerationActivePower. Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
b0b5438 to
75ec189
Compare
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Jan 9, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lost synchronous component count, loss of load, loss of generation and set of element lost to post contingency result.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#2183
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)