[diagnostics-app] Add ability to specify param types #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7820bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
approved these changes
Nov 11, 2024
Chriztiaan
approved these changes
Nov 11, 2024
|
@Omnicpie Thanks for the contribution! I've made minor changes, and it's now published on https://diagnostics-app.powersync.com/ and the latest docker image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user of the diagnostics application to specify a type for a given parameter. This replaces the existing implementation which casts every value as a string, regardless of content.
This does require the user to type well-formed information, so if they specify the type to be an Object or Array, they must write the value so that it is valid for the system to save using
JSON.parse.Currently, this page doesn't explain how to specify values correctly, nor does it alert a user if the value is invalid for conversion, If that needs to be added before this can be merged let me know.
Screenshots
-- Valid Data as viewed in the diagnostics app
-- The same data as above is saved in local storage for use as parameters
-- Saving in other formats than just the obvious