Parsing #5
Parsing #5
Conversation
app/alembic/env.py
Outdated
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| # Construct the database URL from environment variables | |||
| POSTGRES_SERVER = os.getenv("POSTGRES_SERVER", "localhost") | |||
| print(POSTGRES_SERVER) | |||
app/core/config.py
Outdated
|
|
||
| load_dotenv() | ||
|
|
||
| neo4j_config = { |
There was a problem hiding this comment.
can we make this a config provider class please
app/core/crud_utils.py
Outdated
| from app.modules.projects.projects_model import Project | ||
| from datetime import datetime | ||
|
|
||
| # User CRUD operations |
There was a problem hiding this comment.
I am not aligned with the structure of this file, has scope of improvements
- user , projects related stuff sits here , instead of their respective modules
- this is not a class.
The objective of this code feels similar to what can sit in a services file.
app/core/database.py
Outdated
|
|
||
|
|
||
|
|
||
| class SessionManager: |
There was a problem hiding this comment.
why is this needed? we already use get_db() to provide sessions and let them flow via router via dependency injection, example
async def get_conversation_info(
conversation_id: str,
db: Session = Depends(get_db)
):
controller = ConversationController(db)
return await controller.get_conversation_info(conversation_id)
app/firebase_setup.py
Outdated
| import json | ||
| import logging | ||
|
|
||
| def firebase_init(): |
app/models.py
Outdated
| @@ -0,0 +1,19 @@ | |||
| from sqlalchemy.orm import relationship | |||
There was a problem hiding this comment.
this file is not needed, we removed this in my pr before merging, please remove and test.
| @@ -0,0 +1,42 @@ | |||
| from sqlalchemy.orm import Session | |||
| from typing import List, Optional | |||
There was a problem hiding this comment.
redundant, was renamed to chat_history_service, please compare to main and check
| from app.core.mongo_manager import MongoManager | ||
|
|
||
| router = APIRouter() | ||
|
|
There was a problem hiding this comment.
it should be structured in a class
app/modules/utils/ai_helper.py
Outdated
| from app.modules.key_management.secret_manager import get_secret | ||
| from app.core.mongo_manager import MongoDBHelper | ||
|
|
||
| def get_llm_client(user_id, model_name): |
There was a problem hiding this comment.
can we have this part of a class as well
app/modules/utils/model_helper.py
Outdated
| from sqlalchemy.orm import class_mapper | ||
| from sqlalchemy.orm.exc import DetachedInstanceError | ||
|
|
||
| def model_to_dict(model, max_depth=1, current_depth=0): |
app/firebase_setup.py
Outdated
| @@ -0,0 +1,25 @@ | |||
| import os | |||
| import firebase_admin | |||
There was a problem hiding this comment.
also this file should sit inside utils module
No description provided.