feat: initial changes for support for isDevelopmentMode=enabled #192
Conversation
waveywaves
commented
Nov 25, 2024
•
- Skip firebase init in dev mode.
- Add logging for AuthService in dev mode
- Disable PortKey initialization in dev mode
at the time of commit, both ENV and isDevelopmentMode are used interchangeably across the codebase to check if the application is in development mode. This change ensures that we are only checking one environment variable as a single source of truth to check if the application is in development mode or not.
|
Hi @waveywaves some thoughts towards this pull request. The separation between ENV and isDevelopmentMode is intentional in its naming and use case. The ENV signifies the environment the app is running in, signfying configuration to load in dev / stage or prod env. The isDevelopmentMode is a bit different in required use case, it tells the app that it can run without dependencies such as firebase, GitHub configuration etc. The ENV development still needs firebase / gcp / GitHub etc because it simply is about running potpie's backend locally. But isDevelopmentMode disables all these to bring in support for lrunning without most dependencies and support local parsing for example, and other things in future. You might need to redo some stuff in the PR for this. |
|
Hey @vineetshar, ah okay. Thanks for helping me out with that. I'll update this info in the contributing doc in that case if it isn't there. |
This reverts commit 4c249f3.
|
@vineetshar I have updated the PR, lmkwyt |
|
@vineetshar the PR is ready for review. Thank you in advance. |
|
|
@dhirenmathur thank you for looking into this, updated based on your review |
@waveywaves one feedback left about user creation, can we do that as well please. |
|
@vineetshar yes, shall revert to the comment asap |
|
Approving this since disabling the mentioned things work as part of this PR. But development mode will be fully functional once we support parsing (which is to be done today 28th Nov), before that it is not really usable but is outside the scope of this specific pull request. |