feat: public user profile pic #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirenmathur
previously requested changes
Nov 25, 2024
Co-authored-by: Dhiren Mathur <dhiru17398@gmail.com>
Co-authored-by: Dhiren Mathur <dhiru17398@gmail.com>
|
vineetshar
reviewed
Nov 27, 2024
|
Generally looks, good, left one comment needing clarification @Yash-pede I was also wondering if firebase will always return a url even if the user has not uploaded their picture for example? Have we tested this scenario? |
no firebase does not return a url if user does not have a profile picture but for now we are using only github login and it has a random profile pic if not uploaded anything |
vineetshar
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.