fetch history for correct versioning when deploying #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with this template, as the automatic versioning is very nice, but does not work well with github action checkout. For the automatic versioning to work, we rely on the checked out git, as discussed somewhere before (can't find the issue/discussion anymore, might have been the old git).
As the 'setuptools-scm' relies on git metadata and as described here:
actions/checkout#249
this PR solves the issue and produces correct version numbers on deployment by checking out the complete history (including tag names etc...). The performance drawback will hopefully be negligible.