Add ability to guess raw language type using content-type headers #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d33003 to
ba9ce4e
Compare
ba9ce4e to
a73189e
Compare
VShingala
reviewed
Apr 16, 2024
src/lib.js
Outdated
| request.body.options.raw = {}; | ||
| request.body.options.raw.language = Object.keys(LANGUAGE_REGEX_MATCH) | ||
| .find((key) => { | ||
| return LANGUAGE_REGEX_MATCH[key].test(content_type); |
There was a problem hiding this comment.
Can we wrap this around try catch? This is to make sure regex doesn't break entire import in case of bad input.
There was a problem hiding this comment.
Makes sense. I have made the change.
VShingala
reviewed
Apr 16, 2024
95a3ebd to
4e6199b
Compare
4e6199b to
a2eeeb4
Compare
VShingala
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support in
curlConverterto guess raw dataMode language type using headers if available