Fixes issue where cURL in Windows cmd formats were not imported correctly. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/fix-cmd-curl
webholik
reviewed
Feb 6, 2023
webholik
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Original issue: postmanlabs/postman-app-support#5182
Some of copied cURL that were in windows cmd formats were failing to import. Browsers on windows machine provides an option to copy the cURL in windows cmd format as mention below. Such cURLs failed to import.
RCA:
In our code, we always expect the cURL to be in bash-compatible syntax. This made it so that cURL commands where
^(caret) were used for escaping were failing due to incorrect parsing.Fix:
We are introducing a retry mechanism for all failing cURLs. We'll retry the conversion again after replacing certain escae characters and making the cURL command bash compatible. We are also making sure that this retry can only happens once as there's cyclic dependency of function via introducing the
shouldRetryflag to the existingconvertCurlToRequest()function.