E2E test: add alternate Python and R versions #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
8a5edc9 to
8707899
Compare
midleman
approved these changes
Jan 30, 2025
Comment on lines
+65
to
+77
| const primaryPython = process.env.POSITRON_PY_VER_SEL; | ||
|
|
||
| if (primaryPython) { | ||
|
|
||
| await app.workbench.console.barClearButton.click(); | ||
|
|
||
| await app.workbench.console.pasteCodeToConsole('import platform; print(platform.python_version())'); | ||
| await app.workbench.console.sendEnterKey(); | ||
|
|
||
| await app.workbench.console.waitForConsoleContents(primaryPython); | ||
| } else { | ||
| fail('Primary Python version not set'); | ||
| } |
There was a problem hiding this comment.
I don't think you need this check. The test would fail during setup due to this code block:
startInterpreterViaQuickAccess = async (interpreterType: 'Python' | 'R', waitForReady = true) => {
if (!DESIRED_PYTHON || !DESIRED_R) {
throw new Error('Please set env vars: POSITRON_PYTHON_VER_SEL, POSITRON_R_VER_SEL');
}
...
There was a problem hiding this comment.
yeah, thats why I skipped the quick access route. wasn't sure how attached you were to that check
There was a problem hiding this comment.
actually, I might have skipped quick access because I (locally) have a global 3.13.0 and its a lot more work with quick access to pick between two
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding alternate R and Python versions in preparation for multi console tests. One simple R and Python test was added to ensure the installations were successful.
Local setup:
Local env vars:
QA Notes
All tests should pass.
@:scm @:web @:console @:win