E2E test: Positron editors POM #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
midleman
reviewed
Dec 20, 2024
| if (process.platform === 'darwin') { | ||
| await this.code.driver.page.keyboard.press('Meta+N'); | ||
| } else { | ||
| await this.code.dispatchKeybinding('Control+N'); |
|
|
||
| let error: unknown | undefined = undefined; | ||
| let retries = 0; | ||
| while (retries < 10) { |
There was a problem hiding this comment.
Could this be the "expect" toPass() instead?
There was a problem hiding this comment.
yeah, i do like that the basic loops can capture the error and surface it, but this could definitely be a toPass(). i could go either way. it is a little annoying that toPass blocks always just fail on a timeout.
There was a problem hiding this comment.
i will go ahead and convert.... toPass is more concise
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace MS editors POM with one based solely on Playwright
QA Notes
All tests should pass.