Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Positron supports Python 3.13 #5137

Closed
petetronic opened this issue Oct 23, 2024 · 3 comments
Closed

Ensure Positron supports Python 3.13 #5137

petetronic opened this issue Oct 23, 2024 · 3 comments
Assignees
Labels
area: kernels Issues related to Jupyter kernels and LSP servers lang: python

Comments

@petetronic
Copy link
Collaborator

Python 3.13 was released on 2024-10-07. We should ensure Positron can support this version and add it to our matrix.

Supported Versions

@petetronic
Copy link
Collaborator Author

Related, Python 3.8 reached EOL on 2024-10-07. See #5136

@petetronic petetronic added the area: kernels Issues related to Jupyter kernels and LSP servers label Oct 23, 2024
@petetronic petetronic changed the title Ensure Positron support of Python 3.13 Ensure Positron supports Python 3.13 Oct 24, 2024
@juliasilge juliasilge added this to the 2025.01.0 Pre-Release milestone Oct 28, 2024
@isabelizimm isabelizimm self-assigned this Dec 5, 2024
isabelizimm added a commit that referenced this issue Dec 20, 2024
addresses #5136
~addresses #5137~ NOTE: due to `ibis-framework[duckdb]` not being
available for 3.13, we will not be able to test at this time

- Slightly adjust cadence of Python 3.8 from every commit in a PR to
nightly for ipykernel Positron tests (keep as-is for upstream tests,
which only run on earliest and latest versions)
- Add in testing for Python 3.13 

This closely follows the strategy of upstream, which [tests on
3.8-3.13](https://github.com/microsoft/vscode-python/blob/d50b7cca88f7f81cef22516ef557b9aae5e9219e/.github/workflows/pr-check.yml#L150).

### QA Notes

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

should pass CI
@isabelizimm
Copy link
Contributor

isabelizimm commented Dec 20, 2024

Currently, we are not able to test with Python 3.13 since not all of our dependencies are supported on 3.13 yet (namely, ibis-framework[duckdb]). While we are not officially testing, 3.13 can be found by Positron and ipykernel can be installed, you can run things in the console, data explorer, etc.

Image

This might require further research to determine how to bridge the gap between official releases of Python versions and when dependencies support the released version. I've moved this to the next milestone to see if we can turn on all the testing at that point.

isabelizimm added a commit that referenced this issue Jan 24, 2025
In an effort to get testing available for Python 3.13, let's skip the
tests for ibis, since it cannot be downloaded for 3.13 anyway.


### Release Notes

<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
  The note will automatically be tagged with the language.

These notes are typically filled by the Positron team. If you are an
external
  contributor, you may ignore this section.
-->

#### New Features

- addresses #5137 by adding in testing infrastructure for Python 3.13

#### Bug Fixes

- N/A


### QA Notes

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

should pass CI

---------

Signed-off-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>
@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.02.0-118
OS Version          : ubuntu, ci

Test scenario(s)

CI is green.

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kernels Issues related to Jupyter kernels and LSP servers lang: python
Projects
None yet
Development

No branches or pull requests

4 participants