Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTX-1641] Added AKS node driver #389

Closed
wants to merge 1 commit into from
Closed

[PTX-1641] Added AKS node driver #389

wants to merge 1 commit into from

Conversation

vinayakshnd
Copy link
Contributor

@vinayakshnd vinayakshnd commented Dec 30, 2019 •
edited
Loading

Depends on PR in cloudops: libopenstorage/cloudops#45

mborodin-px
mborodin-px reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@mborodin-px mborodin-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix CI issue:

81.90s$ make all
go vet github.com/portworx/torpedo/drivers github.com/portworx/torpedo/drivers/node github.com/portworx/torpedo/drivers/node/aks github.com/portworx/torpedo/drivers/node/aws github.com/portworx/torpedo/drivers/node/gke github.com/portworx/torpedo/drivers/node/ssh github.com/portworx/torpedo/drivers/scheduler github.com/portworx/torpedo/drivers/scheduler/dcos github.com/portworx/torpedo/drivers/scheduler/k8s github.com/portworx/torpedo/drivers/scheduler/openshift github.com/portworx/torpedo/drivers/scheduler/spec github.com/portworx/torpedo/drivers/volume github.com/portworx/torpedo/drivers/volume/portworx github.com/portworx/torpedo/drivers/volume/portworx/schedops github.com/portworx/torpedo/pkg/errors github.com/portworx/torpedo/pkg/log

github.com/portworx/torpedo/drivers/node/aks

drivers/node/aks/aks.go:39:14: undefined: azure.NewAzureClient
make: *** [vet] Error 2
The command "make all" exited with 2.

drivers/node/aks/aks.go Outdated Show resolved Hide resolved
@harsh-px harsh-px added wip and removed do-not-merge labels Jan 6, 2020
harsh-px
harsh-px reviewed Jan 14, 2020
View reviewed changes
drivers/node/aks/aks.go Outdated Show resolved Hide resolved
@vinayakshnd vinayakshnd changed the title [WIP][PTX-1641] Added AKS node driver [PTX-1641] Added AKS node driver Jan 15, 2020
@vinayakshnd vinayakshnd added ready-for-review PR is ready for review and removed wip labels Jan 15, 2020
@vinayakshnd
Copy link
Contributor Author

Jenkins Job with code changes:
https://jenkins.portworx.co/job/Torpedo/job/dummy-tp-2-3-aks/29/console

@vinayakshnd vinayakshnd force-pushed the PTX-1641 branch 3 times, most recently from 81d7cd1 to 009fcc2 Compare January 15, 2020 10:26
rodrigc
rodrigc suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@rodrigc rodrigc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications to Gopkg.lock should not be in your commit. Torpedo has been converted to go modules, so Gopkg.lock has been deleted.

@rodrigc
Copy link
Contributor

rodrigc commented Jan 22, 2020 •
edited
Loading

Torpedo has been converted to go modules.
To add new vendor dependencies you need to follow instructions similar to:

https://github.com/portworx/spawn/blob/master/docs/go-modules.md

@vinayakshnd
Copy link
Contributor Author

Performed bellow steps locally after rebasing the branch with master (after removing Gopkg.lock)

Vinayaks-MacBook-Pro:torpedo vinayak$ go get github.com/libopenstorage/cloudops@master
go: finding github.com/libopenstorage/cloudops master

Vinayaks-MacBook-Pro:torpedo vinayak$ make vendor-update
go mod download
go: finding github.com/prometheus/prometheus v2.9.2+incompatible
go: finding github.com/prometheus/prometheus v2.9.2+incompatible
github.com/prometheus/prometheus@v2.9.2+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required
make: *** [vendor-update] Error 1
Vinayaks-MacBook-Pro:torpedo vinayak$ make vendor
go mod vendor

Vinayaks-MacBook-Pro:torpedo vinayak$ make build
mkdir -p /Users/vinayak/go/src/github.com/portworx/torpedo/bin
go build -tags "daemon"  github.com/portworx/torpedo/drivers github.com/portworx/torpedo/drivers/node github.com/portworx/torpedo/drivers/node/aks github.com/portworx/torpedo/drivers/node/aws github.com/portworx/torpedo/drivers/node/gke github.com/portworx/torpedo/drivers/node/ssh github.com/portworx/torpedo/drivers/scheduler github.com/portworx/torpedo/drivers/scheduler/dcos github.com/portworx/torpedo/drivers/scheduler/k8s github.com/portworx/torpedo/drivers/scheduler/openshift github.com/portworx/torpedo/drivers/scheduler/spec github.com/portworx/torpedo/drivers/volume github.com/portworx/torpedo/drivers/volume/portworx github.com/portworx/torpedo/drivers/volume/portworx/schedops github.com/portworx/torpedo/pkg/errors github.com/portworx/torpedo/pkg/log
# github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/agentpools.go:116:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/agentpools.go:201:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/agentpools.go:291:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/agentpools.go:376:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:136:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:216:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:300:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:374:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:489:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:606:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/containerservice/mgmt/2019-02-01/containerservice/containerservices.go:606:8: too many errors
# github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:106:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:183:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:259:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:335:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:450:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:528:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/availabilitysets.go:645:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/containerservices.go:133:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/containerservices.go:213:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/containerservices.go:297:8: undefined: autorest.GetSendDecorators
vendor/github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2018-06-01/compute/containerservices.go:297:8: too many errors
make: *** [build] Error 2

@nikolaypopov
Copy link
Contributor

nikolaypopov commented Jan 22, 2020 •
edited
Loading

What go version are you using? I had similar issues with using go version below 1.13.

Try this:

  1. export GO111MODULE=on
  2. go get github.com/libopenstorage/cloudops@master
  3. make vendor

@harsh-px
Copy link
Collaborator

@vinayakshnd this issue is discussed in golang/go#33558

Use the replace directive to workaround this.

@thiguetta
Copy link
Contributor

@vinayakshnd I guess it's better collect everything you did, close this PR and start a new one from fresh master

thiguetta
thiguetta suggested changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@thiguetta thiguetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look my comment above since we had a big change in dependency management

@rodrigc
Copy link
Contributor

rodrigc commented Jan 23, 2020

I'm shifting gears today to focus on Torpedo reviews, so will help you with this @vinayakshnd

@rodrigc rodrigc mentioned this pull request Jan 23, 2020
Merged
@rodrigc
Copy link
Contributor

rodrigc commented Jan 23, 2020

Moved to: #398

@rodrigc rodrigc closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiguetta thiguetta thiguetta requested changes

@rodrigc rodrigc rodrigc requested changes

@harsh-px harsh-px Awaiting requested review from harsh-px

@mborodin-px mborodin-px Awaiting requested review from mborodin-px

Assignees
No one assigned
Labels
ready-for-review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinayakshnd @rodrigc @nikolaypopov @harsh-px @thiguetta @mborodin-px