Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import Time in function Import from CSV in case it is available #4555

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pyBlockDev
Copy link

Closes #4554

@pfalcon
Copy link
Contributor

pfalcon commented Feb 27, 2025

Normal time format is HH:mm:ss. This change adhocly applies some random time format instead.

@pyBlockDev
Copy link
Author

Hi @pfalcon,

yes you are right. In my usecase if I export the depot, then PP generates this:

image

This is now possible to read back with PP.
But if somebody has the T10:33:11 then we get an exception. If I use HH:mm:ss then my examples get an exception.
Maybe we could count the number of ":" and make a case decision.
What do you think?

@Nirus2000
Copy link
Member

Hello @pyBlockDev
Thank you for the pull request.
If you take your time again, it would be good to have a look at the Contributing rules and of course check the test case for your change in your branch or create a suitable one.

Regards
Alex 😀

@Nirus2000 Nirus2000 requested a review from buchen February 28, 2025 14:55
@Nirus2000 Nirus2000 added the ! Good first pull request ! First pull request !! Keep friendly :-) label Feb 28, 2025
@pyBlockDev
Copy link
Author

pyBlockDev commented Mar 1, 2025

Hi @Nirus2000,

thanks for your hint. I have added the testcases. Additional I have rechanged the code, used the existing structure and tried to simplify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! Good first pull request ! First pull request !! Keep friendly :-)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time is ignored in CSV Importer
4 participants