Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trade: Add toString() #4520

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Trade: Add toString() #4520

merged 1 commit into from
Feb 23, 2025

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Feb 9, 2025

Useful during developement to debug various algorithms and edge cases.

@pfalcon
Copy link
Contributor Author

pfalcon commented Feb 9, 2025

Another changes along the lines of #3303 . To debug this, and much more diagnostic output will be required. Actually, similar to #3913, I'd propose to add toString() to as many internal classes as possible (this includes various "line items", etc.)

@buchen buchen merged commit 6822d56 into portfolio-performance:master Feb 23, 2025
2 checks passed
@buchen
Copy link
Member

buchen commented Feb 23, 2025

I am not a fan of those debug statements. But I understand they are helpful to understand what is going on. And with the < and > one can also immediately see that this is not shown in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfalcon @buchen