Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new account bookings to FlatEx PDF Importer #4009

Merged
merged 5 commits into from
May 13, 2024
Merged

Add new account bookings to FlatEx PDF Importer #4009

merged 5 commits into from
May 13, 2024

Conversation

ZfT2
Copy link
Contributor

@ZfT2 ZfT2 commented May 10, 2024

  • add account booking for bonus
  • add account booking for claim
  • add account bookings for Zinspilot interest
  • fix an error that tax return booking for options was recorded twice.

@Nirus2000 Nirus2000 added the pdf label May 12, 2024
Nirus2000
Nirus2000 requested changes May 12, 2024
View reviewed changes
Copy link
Member

@Nirus2000 Nirus2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ZfT2
that looks very good. Great work. 👍🏻 👍🏻 👍🏻
Please make the following changes.

Regards
Alex

@Nirus2000
Copy link
Member

Hello @ZfT2
... nice job... 👍🏻

Rebase and merge

@Nirus2000 Nirus2000 requested review from Nirus2000 and removed request for Nirus2000 May 13, 2024 17:23
@Nirus2000 Nirus2000 merged commit 26fafd3 into portfolio-performance:master May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirus2000 Nirus2000 Nirus2000 approved these changes

Assignees
No one assigned
Labels
pdf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZfT2 @Nirus2000