Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIS time display error #88

Closed
vfatman0825 opened this issue Jun 29, 2020 · 5 comments
Closed

AIS time display error #88

vfatman0825 opened this issue Jun 29, 2020 · 5 comments
Assignees
@eried
Labels
bug Something isn't working

Comments

@vfatman0825
Copy link

6876B47DD7934C0965363DA118382E10
The following minutes and seconds are displayed as a date
@vfatman0825 vfatman0825 added the bug Something isn't working label Jun 29, 2020
@eried
Copy link
Member

eried commented Jun 30, 2020

Interesting bug on the parser 🕵️‍♂️ thanks for the report :)

@eried eried self-assigned this Jun 30, 2020
@euquiq
Copy link
Contributor

euquiq commented Jun 30, 2020

https://www.youtube.com/watch?v=WZQ_BjmpyqQ Here can be seen too

euquiq added a commit to euquiq/portapack-mayhem that referenced this issue Jun 30, 2020
@euquiq
Update string_format.cpp
29526dd 
Fixed bug that showed datetime wrongly formed in AIS app (and probably other apps too) as depicted in portapack-mayhem#88
euquiq added a commit to euquiq/portapack-mayhem that referenced this issue Jun 30, 2020
@euquiq
Fixed bug in datetime
9a50684 
As shown in portapack-mayhem#88 ...

Tiny bug but probably responsible for badly forming datetime in several apps, as it is used in ACARS, POCSAG and ADSB_TX (and of course AIS RX)
@euquiq euquiq mentioned this issue Jun 30, 2020
Merged
@eried
Copy link
Member

eried commented Jun 30, 2020

@euquiq found and fixed the problem immediately, can you check it @vfatman0825 ?
https://github.com/eried/portapack-mayhem/releases/download/nightly/portapack_nightly_202006302211.bin

@vfatman0825
Copy link
Author

@euquiq found and fixed the problem immediately, can you check it @vfatman0825 ?
https://github.com/eried/portapack-mayhem/releases/download/nightly/portapack_nightly_202006302211.bin

Thank you very much. This error has been fixed
13b9027ad1cd0feafa56a31bbac965e

@eried
Copy link
Member

eried commented Jul 6, 2020

Awesome!! @euquiq patch was already merged to master for future releases

@eried eried closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eried eried

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eried @euquiq @vfatman0825