feat!: migrate to Svelte 5

[ampled]

Description

This is my attempt to kickstart svelte 5 support. It's probably enough to just allow svelte 5 as a peerDependency considering svelte 5 has backwards compatibility, but I guess it's nice to have this as a starting point for a full migration for projects that use runes mode only.

All tests are passing, though I had to add a line to remove comments from rendered output before comparing it to expected output.

Changes

• Migrated all Svelte components using 1st party migration script, then cleaning up by hand
• Added recommended svelte testing plugin to vite-config following Testing Library setup guide
• Updated packages required for svelte 5 and getting tests running

Solves #78 and #127 (make components optional)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-portabletext	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2025 3:38pm

[socket-security]

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@sveltejs/vite-plugin-svelte@4.0.0 🔁 npm/@sveltejs/vite-plugin-svelte@3.1.0	Transitive: environment	+8	848 kB	svelte-admin
npm/@testing-library/svelte@5.2.4 🔁 npm/@testing-library/svelte@5.1.0	Transitive: eval	+30	3.81 MB	testing-library-bot
npm/eslint-plugin-svelte@2.46.0 🔁 npm/eslint-plugin-svelte@2.39.0	Transitive: environment	+26	3.75 MB	ota-meshi
npm/jsdom@25.0.1 🔁 npm/jsdom@24.0.0	Transitive: environment	+37	10 MB	domenic
npm/prettier-plugin-svelte@3.2.7 🔁 npm/prettier-plugin-svelte@3.2.3	None	0	1.5 MB	dummdidumm
npm/svelte-check@4.0.6 🔁 npm/svelte-check@3.7.1	Transitive: environment, filesystem	+10	5.63 MB	svelte-language-tools-deploy
npm/svelte@5.1.12 🔁 npm/svelte@4.2.17	None	+17	4.75 MB	svelte-admin
npm/typescript@5.6.3 🔁 npm/typescript@5.4.5	None	0	22.4 MB	typescript-bot
npm/vitest@2.1.9 🔁 npm/vitest@1.6.1	Transitive: environment, filesystem, shell, unsafe	+33	4.37 MB	antfu, oreanno, patak, ...1 more

View full report↗︎

[TheOnlyTails]

Would be amazing to see this merged!

[ampled]

@TheOnlyTails

Would be amazing to see this merged!

Until then, you can use this: https://www.npmjs.com/package/@eirikk/portabletext-2-svelte-5

Follow the instructions in the README to not have to rewrite any imports

[mikehwagz]

Anything I can do to help get this merged? It is disappointing that this has taken so long considering Svelte 5 has been out now for a considerable amount of time.

[rdunk]

Hello, we're releasing some significant updates for Svelte shortly. I'll get this reviewed and merged by the end of the week. Thanks for your patience.

[rdunk]

Thank you so much for this, I've done an initial pass and it all looks pretty good to me.

I've just made some suggestions to primarily reduce intermediate $derived values, but I don't think this is critical. I'm by no means an expert in Svelte's reactivity system so there could be good reason for them, let me know what you think either way and I'll get this approved, merged and released asap.

Also, I've run benchmarks against these suggested changes (I'll add the benchmark code in another PR) as I wondered if the intermediate $derived values were performance optimisations, but I haven't been able to discern any meaningful difference. So my suggestions are largely addressing perceived readability, this is subjective so I'll leave it up to you whether or not you want to accept them.

[ampled]

I've just made some suggestions to primarily reduce intermediate $derived values, but I don't think this is critical. I'm by no means an expert in Svelte's reactivity system so there could be good reason for them, let me know what you think either way and I'll get this approved, merged and released asap.

Great! I accepted all suggestions. All the $derived values were directly translated from the existing code, taking old "reactive values" like $: value = portableText.value and converting them to let {value} = $derived(portableText) so no issues with improving on this re: readability ⭐

[rdunk]

Awesome, thank you 🙇 . If you wouldn't mind rebuilding the package-lock.json on your branch to resolve the conflicts I'll get this merged and released.