Merge pull request #671 from thiagobfiorenza/master

[2.2] Correções de PHP Docs, PSR-12 (issue #424) e retirados uses não utilizados.
portabilis · Oct 23, 2019 · aea6e60 · aea6e60
2 parents 3f7207b + c239c5d
commit aea6e60
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 17 deletions.
diff --git a/app/Http/Controllers/BatchEnrollmentController.php b/app/Http/Controllers/BatchEnrollmentController.php
@@ -85,7 +85,6 @@ public function viewEnroll(
      * Lista as enturmações da turma e possibilita a desenturmação em lote.
      *
      * @param LegacySchoolClass $schoolClass
-     * @param EnrollmentService $enrollmentService
      *
      * @return View
      */

diff --git a/app/Http/Requests/BatchEnrollmentRequest.php b/app/Http/Requests/BatchEnrollmentRequest.php
@@ -3,7 +3,6 @@
 namespace App\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
-use Illuminate\Support\Arr;
 
 class BatchEnrollmentRequest extends FormRequest
 {

diff --git a/app/Http/Requests/EnrollmentRequest.php b/app/Http/Requests/EnrollmentRequest.php
@@ -3,7 +3,6 @@
 namespace App\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
-use Illuminate\Support\Arr;
 
 class EnrollmentRequest extends FormRequest
 {

diff --git a/app/Listeners/AuthenticatedUser.php b/app/Listeners/AuthenticatedUser.php
@@ -13,7 +13,7 @@ class AuthenticatedUser
      *
      * @param Authenticated $event
      *
-     * @return void
+     * @throws ValidationException
      */
     public function handle(Authenticated $event)
     {

diff --git a/app/Mail/ErrorTrackerMail.php b/app/Mail/ErrorTrackerMail.php
@@ -25,7 +25,9 @@ class ErrorTrackerMail extends Mailable implements ShouldQueue
     /**
      * Create a new message instance.
      *
-     * @return void
+     * @param $to
+     * @param $subject
+     * @param $content
      */
     public function __construct($to, $subject, $content)
     {

diff --git a/app/Models/Individual.php b/app/Models/Individual.php
@@ -75,6 +75,8 @@ public function getRealNameAttribute()
     }
 
     /**
+     * @param $value
+     *
      * @return string
      */
     public function getMotherNameAttribute($value)
@@ -87,6 +89,8 @@ public function getMotherNameAttribute($value)
     }
 
     /**
+     * @param $value
+     *
      * @return string
      */
     public function getFatherNameAttribute($value)
@@ -99,6 +103,8 @@ public function getFatherNameAttribute($value)
     }
 
     /**
+     * @param $value
+     *
      * @return string
      */
     public function getGuardianNameAttribute($value)

diff --git a/app/Models/School.php b/app/Models/School.php
@@ -3,7 +3,6 @@
 namespace App\Models;
 
 use Illuminate\Database\Eloquent\Model;
-use App\Models\Enrollment;
 
 class School extends Model
 {

diff --git a/app/Notifications/ResetPasswordNotification.php b/app/Notifications/ResetPasswordNotification.php
@@ -3,9 +3,8 @@
 namespace App\Notifications;
 
 use Illuminate\Bus\Queueable;
-use Illuminate\Notifications\Notification;
-use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Notifications\Messages\MailMessage;
+use Illuminate\Notifications\Notification;
 
 class ResetPasswordNotification extends Notification
 {

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -2,22 +2,18 @@
 
 namespace App\Providers;
 
-use App\Models\SchoolManager;
-use App\Observers\SchoolManagerObserver;
+use App\Models\LegacyInstitution;
 use App\Providers\Postgres\DatabaseServiceProvider;
-use Exception;
 use App\Services\CacheManager;
-use App\Models\LegacyInstitution;
 use App\Services\StudentUnificationService;
 use Barryvdh\Debugbar\ServiceProvider as DebugbarServiceProvider;
-use iEducar\Support\Navigation\Breadcrumb;
+use Exception;
 use iEducar\Modules\ErrorTracking\HoneyBadgerTracker;
 use iEducar\Modules\ErrorTracking\Tracker;
+use iEducar\Support\Navigation\Breadcrumb;
 use Illuminate\Database\Eloquent\Collection;
-use Illuminate\Http\Request;
 use Illuminate\Pagination\Paginator;
 use Illuminate\Support\Facades\Auth;
-use Illuminate\Support\Facades\Blade;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Schema;
 use Illuminate\Support\ServiceProvider;

diff --git a/app/Services/SchoolClass/AvailableTimeService.php b/app/Services/SchoolClass/AvailableTimeService.php
@@ -56,8 +56,8 @@ public function isAvailable(int $studentId, int $schoolClassId)
 
         $otherSchoolClass = $schoolClassQuery->get();
 
-        foreach ($otherSchoolClass as $otherSchoolClass) {
-            if ($this->schedulesMatch($schoolClass, $otherSchoolClass)) {
+        foreach ($otherSchoolClass as $oneSchoolClass) {
+            if ($this->schedulesMatch($schoolClass, $oneSchoolClass)) {
                 return false;
             }
         }