Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix stop iterator bug in jqpy #1059

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

Tankilevitch
Copy link
Contributor

Description

What - Fixed StopIteration error which was happening with the new jq.py package where trying to get a value from a an empty list using iterator caused the thread to stop and thus the whole resync to stuck

Exception in callback <function _chain_future.<locals>._set_state at 0x10678ed40>
handle: <Handle _chain_future.<locals>._set_state>
Traceback (most recent call last):
  File "uvloop/cbhandles.pyx", line 63, in uvloop.loop.Handle._run
  File "/Users/tomtankilevitch/.pyenv/versions/3.11.4/lib/python3.11/asyncio/futures.py", line 383, in _set_state
    _copy_future_state(other, future)
  File "/Users/tomtankilevitch/.pyenv/versions/3.11.4/lib/python3.11/asyncio/futures.py", line 359, in _copy_future_state
    dest.set_exception(_convert_future_exc(exception))
TypeError: StopIteration interacts badly with generators and cannot be raised into a Future

Why -

How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Integration testing checklist

  • Integration able to create all default resources from scratch
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Resync finishes successfully
  • If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • Docs PR link here

Preflight checklist

  • Handled rate limiting
  • Handled pagination
  • Implemented the code in async
  • Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@Tankilevitch Tankilevitch requested a review from a team as a code owner October 1, 2024 21:08
@github-actions github-actions bot added the size/M label Oct 1, 2024
@Tankilevitch Tankilevitch merged commit faacf8a into main Oct 1, 2024
15 checks passed
@Tankilevitch Tankilevitch deleted the fix-stop-iterator-bug-in-jqpy branch October 1, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants