Resolve node_modules relative to package.json #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the following project structure:
I can add the
package.json
to sonar.sources, but nothing is ever found, becausenode_modules
folder is expected to reside inmoduleBaseDir
(which is root in this example).I thought about supporting the old & and new behavior and searching for the
node_modules
in two locations, but I don't think I have ever come across a project wherenode_modules
is not located next topackage.json
.I also had to restructure the test sources, because I could not easily add the a new test case.
@derkoe can you please take a look?