Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Sonar 10 and 9.5+ #375

Merged
merged 5 commits into from
Jul 15, 2023

Conversation

fvclaus
Copy link
Contributor

@fvclaus fvclaus commented Jun 25, 2023

Fixes #373

I tested with Sonarqube 10.1, but this should with Sonar 9.5+, because this is the plugin API dependency version that I use. For the 10.x release there haven't been any breaking changes so the plugin API is still using 9.x. 9.5 was the first release were the plugin API was released separately, that's why I choose that version. There is a good chance that this will work with 9.0 - 9.4 as well.

I removed some deprecated classes that did not compile anymore. The frontend wasn't working because of the stricter CSP header that does not allow Vue.js template strings.

@fvclaus
Copy link
Contributor Author

fvclaus commented Jun 25, 2023

@fvclaus
Copy link
Contributor Author

fvclaus commented Jul 3, 2023

@derkoe can you please take a look at this?

@derkoe derkoe changed the title Compatibility with Sonar 9.5+ Compatibility with Sonar 10 and 9.5+ Jul 6, 2023
@derkoe derkoe self-requested a review July 6, 2023 06:54
@derkoe
Copy link
Contributor

derkoe commented Jul 6, 2023

Just tried this with SonarQube 10.1 - still shows a blank screen. Nothing in the console log.

image

@fvclaus
Copy link
Contributor Author

fvclaus commented Jul 6, 2023

Just tried this with SonarQube 10.1 - still shows a blank screen. Nothing in the console log.

image

This is what I said in the mail. The administration is still broken, because of the CSP violation. I only touched the dashboard. Up until yesterday, I didn't even know how to get to the administration page, until another user pointed out to me that it is still broken.

@fvclaus
Copy link
Contributor Author

fvclaus commented Jul 6, 2023

@derkoe I fixed the administration page:

image

You might need to reload with Ctrl+Shift+R to bypass the cached version of the old frontend.

@derkoe
Copy link
Contributor

derkoe commented Jul 15, 2023

Now, we only have to figure out a way to bootstrap the data (mostly SPDX licenses)

@derkoe derkoe merged commit 0eda4ec into porscheinformatik:master Jul 15, 2023
@fvclaus fvclaus deleted the sonar-9.5 branch October 4, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonarqube Version 10.0 Compatibility
2 participants