live queries #1408
live queries #1408
Conversation
packages/client/src/index.ts
Outdated
|
|
||
| sse.onmessage = (event) => { | ||
| // @ts-ignore | ||
| callback(prepared.mapResult(JSON.parse(event.data), true).rows); |
There was a problem hiding this comment.
Any error handling to consider here as well?
packages/client/src/index.ts
Outdated
| } else { | ||
| return client.live( | ||
| (db) => db.select().from(status), | ||
| () => { | ||
| _query(client.db).then(onData).catch(onError); | ||
| }, | ||
| onError, | ||
| ); |
There was a problem hiding this comment.
Slightly strange block lol but I follow
|
|
||
| build.initNamespace({ isSchemaRequired: false }); |
| if (listenConnection) { | ||
| if (listenConnection.dialect === "postgres") { | ||
| listenConnection.connection.release(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why is listenConnection not a property of database ? They seem to be passed around together.
packages/core/src/client/index.ts
Outdated
| } catch (error) { | ||
| return c.text((error as Error).message, 500); | ||
| } |
There was a problem hiding this comment.
May want to strip some of the details from this error object before returning, but can add this after prerelease.
packages/core/src/client/index.ts
Outdated
| }), | ||
| }); | ||
| } | ||
| statusResult = await statusResolver.promise; |
There was a problem hiding this comment.
This waits for the next status update?
| export const client = ({ db }: { db: ReadonlyDrizzle<Schema> }) => { | ||
| // @ts-ignore | ||
| const session: PgSession = db._.session; |
There was a problem hiding this comment.
Does this mean all queries will use the same connection? Seems important to use a pool here.
There was a problem hiding this comment.
Variable wasn't being used, deleted
packages/core/src/database/index.ts
Outdated
| await sql | ||
| .raw(` | ||
| CREATE OR REPLACE FUNCTION ${notification} | ||
| RETURNS trigger | ||
| LANGUAGE plpgsql | ||
| AS $$ | ||
| BEGIN | ||
| NOTIFY ${channel}; | ||
| RETURN NULL; | ||
| END; | ||
| $$;`) | ||
| .execute(qb.internal); | ||
|
|
||
| await sql | ||
| .raw(` | ||
| CREATE OR REPLACE TRIGGER ${trigger} | ||
| AFTER INSERT OR UPDATE OR DELETE | ||
| ON "${preBuild.namespace}"._ponder_status | ||
| FOR EACH STATEMENT | ||
| EXECUTE PROCEDURE ${notification};`) | ||
| .execute(qb.internal); | ||
| }); |
There was a problem hiding this comment.
My instinct is that these should happen in the same spot that we create the _ponder_status table (if not exists).
There was a problem hiding this comment.
The problem is that the function that creates the status table (migrate()) isn't always run when getListenConnection() is run. For example the serve command. We might be able to come up with a better solution than I have now but that was my original reason for making this change.
packages/core/src/database/index.ts
Outdated
| if (dialect === "postgres") { | ||
| return { | ||
| dialect: "postgres", | ||
| connection: await (driver as PostgresDriver).internal.connect(), |
There was a problem hiding this comment.
What happens if this connection drops?
* @ponder/react * example working * include all react-query options * fix react build * client docs * react docs * docs: --------- Co-authored-by: typedarray <90073088+0xOlias@users.noreply.github.com>
inject clients into api file
* react packaging wip * build script * quick fix for entrypoint issue * test recursive * fix postinstall * fix server logs and port regression * fix graphql middleware issue * example cleanup * docs --------- Co-authored-by: typedarray <90073088+0xOlias@users.noreply.github.com>
No description provided.