Feat: Multiple Block Ranges #1384
Open
+430
−313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyscott18
reviewed
Jan 21, 2025
| import { buildLogFactory } from "./factory.js"; | ||
|
|
||
| type BlockRange = [number | "latest", number | "realtime" | "latest"]; |
There was a problem hiding this comment.
Could you add some comments here about what each of these values mean?
There was a problem hiding this comment.
added in the last commit
Comment on lines
70
to
83
| const rawBlockRanges: [number, number | "realtime"][] = | ||
| blocks === undefined || blocks.length === 0 | ||
| ? [[0, "realtime"]] | ||
| : blocks.every((b) => Array.isArray(b)) | ||
| ? blocks.map(([fromBlock, toBlock]) => [ | ||
| fromBlock === "latest" ? latest : fromBlock, | ||
| toBlock === "latest" ? latest : toBlock, | ||
| ]) | ||
| : [ | ||
| [ | ||
| blocks[0] === "latest" ? latest : blocks[0], | ||
| blocks[1] === "latest" ? latest : blocks[1], | ||
| ], | ||
| ]; |
There was a problem hiding this comment.
Looks like there is a type error in here
Comment on lines
154
to
156
| const latest: Hex = await network.transport({ chain }).request({ | ||
| method: "eth_blockNumber", | ||
| }); |
There was a problem hiding this comment.
Does this request happen even if there are no tags used in blocks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1377. Handles multiple block ranges by pointing each resolved block range to its separate source.