Speed up the initial fetch

[bronenos]

If we have about 10k objects, we don't have to sort these objects 10k times.
So, lets sort each section just once after all relative objects have been inserted.

[polqf]

One liner .forEach { $0.sort() } please 🙏

[isaacroldan]

The idea is interesting, but i think you are abusing map, you are creating an array of Sections the same size of the Objects array, and that doesn't make sense, forcing you to then do a set later.

My solution would be:

objects.forEach { getOrCreateSection($0).insert($0) }
sections.forEach { $0.sort() }

What do you think?

[bronenos]

Oh, yes, I forgot about internal sections.
The only problem is - if we will have two sections, each with 10k objects, then in case of filling just one section, the second would be sorted too?

If not, I agree with you.

[polqf]

@bronenos When a section runs out of objects, it is removed. So if a user only has 10k elements in one sections, that's the only one that is going to be sorted

[bronenos]

Okay, well, who will add the changes we discussed above?

[polqf]

Whatever you prefer @bronenos , if you cannot do it, we'll do it whenever we can 👍

[bronenos]

Well, ok, I will

[isaacroldan]

Rebase with master, there are new commits there conflicting

Also, Add tests for tests for the new insert and sort functions please :)

[bronenos]

Done

[isaacroldan]

please use the beforeEach closure.
If you need to clean between tests (and you should), use the afterEach

(apply to all tests ;) )

[polqf]

Hi @bronenos ,

There are cases where you are using the it closure incorrectly, they are easily fixed by using beforeEach and afterEach when necessary

[polqf]

Merging it, will do a PR with the fixes commented above

Thanks @bronenos

[bronenos]

Ok, thank you.
I'm not familiar with this library, did not use it before.