This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Defending against section.deleteOutdatedObject returning a -1 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +120,7 @@ class RealmResultsCache<T: Object> { | |||
| guard let section = sectionForOutdateObject(object), | |||
| let sectionIndex = indexForSection(section) else { continue } | |||
| let index = section.deleteOutdatedObject(object) | |||
| guard index != -1 else { continue } | |||
There was a problem hiding this comment.
Can we change the -1 for a constant like NOT_FOUND?
There was a problem hiding this comment.
Yes, that would be great. Also, the guard for section.indexForOutdatedObject(object) being different from -1 seems to be in many places. Consider wrapping the whole validation in one method/class.
|
💬 👍 |
e99e34d to
f7bd61d
Compare
| @@ -38,22 +38,22 @@ class Section<T: Object> : NSObject { | |||
| return objects.indexOfObject(object) | |||
| } | |||
|
|
|||
| func delete(object: T) -> Int { | |||
| func delete(object: T) -> Int? { | |||
|
👍 |
polqf
added a commit
that referenced
this pull request
Jan 5, 2016
Defending against section.deleteOutdatedObject returning a -1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
-1when the object is not found👻 GIF