Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light theme identicon background #9802

Merged
merged 1 commit into from
Aug 21, 2023
+5 −44
Merged

Fix light theme identicon background #9802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"@types/react-dom": "^18.2.7",
"@types/react-router-dom": "^5.3.3",
"@types/store": "^2.0.2",
"@types/styled-theming": "^2.2.5",
"concurrently": "^8.2.0",
"devtron": "^1.4.0",
"dnslink-cloudflare": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/apps/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
}

[data-theme="light"] {
--bg-identicon-circle: inherit;
--bg-identicon-circle: #eee;
--bg-input: #ffffff;
--bg-input-error: #fff6f6;
--bg-inverse: rgba(244, 242, 240, 0.91);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/src/IdentityIcon/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const StyledBaseIdentityIcon = styled(BaseIdentityIcon)`
display: inline-block;
overflow: hidden;

circle:first-child {
svg circle:first-child {
fill: var(--bg-identicon-circle);
}
`;
Expand Down
44 changes: 3 additions & 41 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4601,7 +4601,7 @@ __metadata:
languageName: node
linkType: hard

"@types/hoist-non-react-statics@npm:*, @types/hoist-non-react-statics@npm:^3.3.0":
"@types/hoist-non-react-statics@npm:^3.3.0":
version: 3.3.1
resolution: "@types/hoist-non-react-statics@npm:3.3.1"
dependencies:
Expand Down Expand Up @@ -5003,27 +5003,6 @@ __metadata:
languageName: node
linkType: hard

"@types/styled-components@npm:*":
version: 5.1.26
resolution: "@types/styled-components@npm:5.1.26"
dependencies:
"@types/hoist-non-react-statics": "*"
"@types/react": "*"
csstype: ^3.0.2
checksum: 84f53b3101739b20d1731554fb7735bc2f3f5d050a8b392e9845403c8c8bbd729737d033978649f9195a97b557875b010d46e35a4538564a2d0dbcce661dbf76
languageName: node
linkType: hard

"@types/styled-theming@npm:^2.2.5":
version: 2.2.5
resolution: "@types/styled-theming@npm:2.2.5"
dependencies:
"@types/styled-components": "*"
csstype: ^3.0.2
checksum: 4afc95c72a73fbcf99cdf5dcd025f46554b551bcd6129f5c041dbf253d779a9b6cf105f69dc828399fc1a91a34766799da6ff7585818ec405d3adc98d56be334
languageName: node
linkType: hard

"@types/stylis@npm:^4.0.2":
version: 4.2.0
resolution: "@types/stylis@npm:4.2.0"
Expand Down Expand Up @@ -5091,16 +5070,7 @@ __metadata:
languageName: node
linkType: hard

"@types/yargs@npm:^17.0.1":
version: 17.0.10
resolution: "@types/yargs@npm:17.0.10"
dependencies:
"@types/yargs-parser": "*"
checksum: f0673cbfc08e17239dc58952a88350d6c4db04a027a28a06fbad27d87b670e909f9cd9e66f9c64cebdd5071d1096261e33454a55868395f125297e5c50992ca8
languageName: node
linkType: hard

"@types/yargs@npm:^17.0.8":
"@types/yargs@npm:^17.0.1, @types/yargs@npm:^17.0.8":
version: 17.0.24
resolution: "@types/yargs@npm:17.0.24"
dependencies:
Expand Down Expand Up @@ -7301,14 +7271,7 @@ __metadata:
languageName: node
linkType: hard

"ci-info@npm:^3.1.1":
version: 3.2.0
resolution: "ci-info@npm:3.2.0"
checksum: c68995a94e95ce3f233ff845e62dfc56f2e8ff1e3f5c1361bcdd520cbbc9726d8a54cbc1a685cb9ee19c3c5e71a1dade6dda23eb364b59b8e6c32508a9b761bc
languageName: node
linkType: hard

"ci-info@npm:^3.2.0":
"ci-info@npm:^3.1.1, ci-info@npm:^3.2.0":
version: 3.8.0
resolution: "ci-info@npm:3.8.0"
checksum: d0a4d3160497cae54294974a7246202244fff031b0a6ea20dd57b10ec510aa17399c41a1b0982142c105f3255aff2173e5c0dd7302ee1b2f28ba3debda375098
Expand Down Expand Up @@ -15518,7 +15481,6 @@ fsevents@~2.3.2:
"@types/react-dom": ^18.2.7
"@types/react-router-dom": ^5.3.3
"@types/store": ^2.0.2
"@types/styled-theming": ^2.2.5
concurrently: ^8.2.0
devtron: ^1.4.0
dnslink-cloudflare: ^3.0.0
Expand Down