Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make System Parachains trusted Teleporters #62

Closed
wants to merge 37 commits into from
Closed

Make System Parachains trusted Teleporters #62

wants to merge 37 commits into from

Conversation

NachoPal
Copy link
Contributor

Make System Parachain trusted Teleporters of each other. System Parachains should be able to teleport their native asset between them.

Depends on: paritytech/polkadot-sdk#1368

ggwpez and others added 30 commits September 14, 2023 15:06
@ggwpez
Import Runtimes from Polkadot-SDK v1.1.0-rc2 (f60318f686)
216db97 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Rename glutton -> gluttonS
432d49b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add glutton-kusama to the workspace
4ce1473 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Structure workspace config
de16d6f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Use staging-parachain-info crate
56b95fb 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Use crates-io dependencies
06de008 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Cargo.lock
37ef1da 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update README
c72187f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update .gitignore and rustfmt
d40f4c6 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Manual TOML formatting
9c963a4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add one more clippy lint from Polkadot-SDK
4f24f1f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Retry CI
4cb280c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Use workspace version 1.1.0
887cb3e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Cleanup Cargo.toml and rename glutton-runtime
7e64a4e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Delete empty CHANGELOG
b88365b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add GPL-3.0 license
2f52268 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Use version 1.0.0
423936e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update lockfile
7d4aaa0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr
Hide weight files and Cargo.lock by default in diffs
6579111
@ggwpez @bkchr
Set authors to the Fellowship
47be430 
Co-authored-by: Bastian Köcher <git@kchr.de>
@NachoPal
make system paras teleporters
55b2d23
@NachoPal
fix indent
7c039df
@NachoPal
fmt
e4616a7
@ggwpez @liamaharon
Typo
b34be44 
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
@bkchr
Adds chain spec generator
1183e6b
@ggwpez
Update system-parachain weights
6c599a3 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update system-parachain weights again
74e4217 
Just a sanity check for the consistency.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@bkchr
Merge branch 'oty-import-v1.1.0-rc2' of github.com:polkadot-fellows/r…
122d3b2 
…untimes into oty-import-v1.1.0-rc2
@ggwpez
Merge remote-tracking branch 'origin/oty-import-v1.1.0-rc2' into oty-…
f4cab62 
…import-v1.1.0-rc2
@ggwpez
Revert everything unrelated
8b218e4 
git revert -m 1 c72187f^..f4cab62 --no-commit

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@NachoPal NachoPal mentioned this pull request Oct 16, 2023
Merged
@pmensik
Copy link

pmensik commented Oct 18, 2023 •
edited
Loading

I definitely support merging this PR so Bridge Hub collators are able to withdraw deposits they have sent to the chain. Taking care of this is very much appreciated!

@bkchr
Copy link
Contributor

bkchr commented Oct 19, 2023

@NachoPal please fix compilation. The type is probably not yet available, so best to copy it.

@bkontur
Copy link
Contributor

bkontur commented Oct 19, 2023

@NachoPal please fix compilation. The type is probably not yet available, so best to copy it.

@NachoPal in case of copy, ConcreteAssetFromSystem depends on ParaId::from(*id).is_system() which has been changed here. If this constant change is not part of actual polkadot-parachain-primitives dependency (looks like v1.0.0 it is not, only v2.0.0 has it), so you should better go with < 2000,

@NachoPal
Copy link
Contributor Author

@bkontur Yeah, I talked to @bkchr, and IMHO unless it is a bug fix that needs to be asap in the next release, better to avoid this kind of patching that can potentially lead to errors in the future.

This PR will wait to be merged until the missing type is available.

@joepetrowski joepetrowski mentioned this pull request Oct 20, 2023
Closed
@joepetrowski joepetrowski mentioned this pull request Nov 21, 2023
Merged
5 tasks
@bkchr
Copy link
Contributor

bkchr commented Dec 7, 2023

Was already done in: #87

@bkchr bkchr closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

@bkontur bkontur bkontur approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

@KiChjang KiChjang KiChjang approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.