Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI + one integration test for bridge-hub-kusama #397

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Fix CI + one integration test for bridge-hub-kusama #397

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
454070d
Remove `continue-on-error`
bkontur Jul 23, 2024
6a765a7
Add unique step name to avoid confusion
bkontur Jul 23, 2024
9041a8b
Nits
bkontur Jul 23, 2024
bf25891
Update .github/workflows/changelog.yml
bkontur Jul 23, 2024
dc41352
Update .github/workflows/changelog.yml
bkontur Jul 23, 2024
02a4d79
Fix test - we don't expect delivery fees for `ExportMessage` on the B…
bkontur Jul 24, 2024
a8ec0dd
Typos
bkontur Jul 24, 2024
e813ddb
Change `Versioned*::V4` to `Versioned*::from` to use latest (for easi…
bkontur Jul 24, 2024
c93ccb1
Merge remote-tracking branch 'polkadot-fellows/main' into bko-fix-tests
bkontur Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Verify Changelog

# If you modify more test jobs, ensure that you add them as required to the job "confirmTestPassed"
# If you modify more test jobs, ensure that you add them as required to the job "confirmChangelogChecksPassed"
# which is located at the end of this file (more info in the job)

on:
Expand All @@ -16,7 +16,7 @@ concurrency:
cancel-in-progress: true

jobs:

# Job required by "confirmChangelogChecksPassed"
verify-changelog-updated:
name: Verify that Changelog is Updated
runs-on: ubuntu-latest
Expand All @@ -32,6 +32,7 @@ jobs:
if: steps.changed.outputs.matched != 'true' && !contains(github.event.pull_request.body, '[x] Does not require a CHANGELOG entry')
run: echo "::error::CHANGELOG.md has not been modified. Either modify the file or check the checkbox in the body" && exit 1

# Job required by "confirmChangelogChecksPassed"
verify-changelog-valid:
name: Verify that Changelog is valid
runs-on: ubuntu-latest
Expand All @@ -50,10 +51,10 @@ jobs:
# If you add more jobs, remember to add them to the "needs" array.
confirmChangelogChecksPassed:
runs-on: ubuntu-latest
name: All tests passed
name: All checks passed
bkontur marked this conversation as resolved.
Show resolved Hide resolved
# If any new job gets added, be sure to add it to this list
needs:
- verify-changelog-updated
- verify-changelog-valid
steps:
- run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY
- run: echo '### Good job! All the checks passed 🚀' >> $GITHUB_STEP_SUMMARY
bkontur marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
# Job required by "confirmTestPassed"
runtime-test:
needs: [runtime-matrix]
continue-on-error: true
runs-on: ubuntu-22.04
strategy:
matrix:
Expand Down Expand Up @@ -97,7 +96,6 @@ jobs:
# Job required by "confirmTestPassed"
integration-test:
needs: [integration-test-matrix]
continue-on-error: true
runs-on: ubuntu-22.04
strategy:
matrix:
Expand Down
Loading