Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split --workspace test pipeline to separate jobs #189

Merged

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Feb 15, 2024

  • Does not require a CHANGELOG entry

@bkontur bkontur marked this pull request as ready for review February 15, 2024 15:19
acatangiu pushed a commit to paritytech/polkadot-sdk that referenced this pull request Feb 16, 2024
…backport for 1.5) (#3357)

This PR should fix compilation for BridgeHub runtimes with
`runtime-benchmarks`. This problem occurs only if we try to build exact
package:
```
cargo test -p bridge-hub-rococo-runtime --release --features=runtime-benchmarks,try-runtime
cargo test -p bridge-hub-westend-runtime --release --features=runtime-benchmarks,try-runtime
```
This problem was discovered in the `fellows` repo when trying to split
test pipelines per runtime:
polkadot-fellows/runtimes#189. E.g.
https://github.com/polkadot-fellows/runtimes/actions/runs/7918178465/job/21616001877?pr=189

Relevant patched crates:
- asset-test-utils
- bridge-hub-test-utils
- parachains-runtimes-test-utils
acatangiu pushed a commit to paritytech/polkadot-sdk that referenced this pull request Feb 16, 2024
…backport for 1.6) (#3356)

This PR should fix compilation for BridgeHub runtimes with
`runtime-benchmarks`. This problem occurs only if we try to build exact
package:
```
cargo test -p bridge-hub-rococo-runtime --release --features=runtime-benchmarks,try-runtime
cargo test -p bridge-hub-westend-runtime --release --features=runtime-benchmarks,try-runtime
```
This problem was discovered in the `fellows` repo when trying to split
test pipelines per runtime:
polkadot-fellows/runtimes#189. E.g.
https://github.com/polkadot-fellows/runtimes/actions/runs/7918178465/job/21616001877?pr=189

Relevant patched crates:
- asset-test-utils
- bridge-hub-test-utils
- parachains-runtimes-test-utils
Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@bkchr
Copy link
Contributor

bkchr commented Feb 19, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) February 19, 2024 12:46
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkontur
Copy link
Contributor Author

bkontur commented Feb 19, 2024

all the pipelines are green, so what is this waiting for test Expected — Waiting for status to be reported ?

image

@bkontur
Copy link
Contributor Author

bkontur commented Feb 19, 2024

all the pipelines are green, so what is this waiting for test Expected — Waiting for status to be reported ?

image

hmm, probably, could be related to the renamed:

jobs:
   test:
   ...

https://github.com/polkadot-fellows/runtimes/pull/189/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R14-R15

before there was just one test: and now we have multiple jobs: integration-test: / runtime-test: / build-chain-spec-generator:,
so should we change something in github action configuration?

.github/workflows/test.yml Outdated Show resolved Hide resolved
auto-merge was automatically disabled February 19, 2024 14:13

Head branch was pushed to by a user without write access

@bkchr
Copy link
Contributor

bkchr commented Feb 19, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 66519d7 into polkadot-fellows:main Feb 19, 2024
28 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkontur bkontur deleted the bko-split-tests-ci branch February 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants