Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime API impls: gas_price, block_number, balance, code_at #9

Merged
merged 12 commits into from
Jun 4, 2020
Merged

Runtime API impls: gas_price, block_number, balance, code_at #9

merged 12 commits into from
Jun 4, 2020

Conversation

tgmichel
Copy link
Contributor

From #7 includes:

  • EthApi::gas_price
  • EthApi::block_number
  • EthApi::balance
  • EthApi::code_at

@sorpaas sorpaas changed the title Runtime API impls Runtime API impls: gas_price, block_number, balance, code_at May 29, 2020
@sorpaas
Copy link
Member

sorpaas commented May 29, 2020

Just a small grumble -- this PR is okay, but if we can do one PR for each RPC method, that would be slightly easier to review (and faster to merge!).

sorpaas
sorpaas reviewed May 29, 2020
View reviewed changes
@sorpaas sorpaas mentioned this pull request May 29, 2020
Merged
@tgmichel tgmichel mentioned this pull request Jun 1, 2020
Open
38 tasks
sorpaas
sorpaas reviewed Jun 1, 2020
View reviewed changes
@sorpaas
Copy link
Member

sorpaas commented Jun 2, 2020

CI still fails.

@tgmichel
Copy link
Contributor Author

tgmichel commented Jun 2, 2020 •
edited
Loading

It uses paritytech/substrate#6191, and it's not merged yet

460 |             evm::Module::<Runtime>::account_codes(address)
    |                                     ^^^^^^^^^^^^^
    |                                     |
    |                                     function or associated item not found in `pallet_evm::Module<Runtime>`
    |                                     help: there is an associated function with a similar name: `account_id`

@sorpaas
Copy link
Member

sorpaas commented Jun 2, 2020

You can update the vendor folder to that PR. We pin by commit, not master.

@tgmichel
Merge branch 'master' into tgmichel-tracking-7
a155ab5 
# Conflicts:
#	rpc/primitives/src/lib.rs
#	template/runtime/src/lib.rs
@sorpaas sorpaas merged commit c9777b4 into polkadot-evm:master Jun 4, 2020
@tgmichel tgmichel deleted the tgmichel-tracking-7 branch October 7, 2020 09:13
dnjscksdn98 referenced this pull request in bifrost-platform/bifrost-frontier Mar 2, 2023
@dnjscksdn98
debug log #9
099e5ed
keithtensor added a commit to keithtensor/frontier that referenced this pull request Jan 13, 2025
@keithtensor
Merge pull request polkadot-evm#9 from gztensor/remove-aura-dep
50823a2 
Make `fp-rpc` consensus algorithm agnostic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorpaas sorpaas sorpaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgmichel @sorpaas