Ensure no error is possible in apply_validated_transaction and fix correct_and_deposit_fee
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok it's much clearer, thanks :) My misunderstanding came from the fact that I thought that in case of reverting an ethereum transaction, a DispatchError was returned and that the extrinsic failed from the substrate point of view. In fact, even when the ethereum transaction reverts, substrate will consider that the extrinsic execution was successful. |
librelois
approved these changes
Oct 13, 2021
librelois
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Oct 13, 2021
…`correct_and_deposit_fee` (polkadot-evm#497) * Ensure no error is possible in `apply_validated_transaction` * Fix lints * Fix correct_and_deposit_fee should not be able to error * Change ensure to assert * Fix tests
abhijeetbhagat
pushed a commit
to web3labs/frontier
that referenced
this pull request
Jan 11, 2023
…`correct_and_deposit_fee` (polkadot-evm#497) * Ensure no error is possible in `apply_validated_transaction` * Fix lints * Fix correct_and_deposit_fee should not be able to error * Change ensure to assert * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In normal
Ethereum::transactexecution, we do not have any Substrate fee wrappers. As a result,apply_validated_transactionshould never error out, because in that situation no fee will be paid. On the other hand, we can return Substrate dispatchable error in the firstensure_ethereum_transactionline, because if it's not, then it is actually wrapped with Substrate fee handling logic.This PR also fixes an issue in
correct_and_deposit_fee, in that because we modified state before, it should not be able to return any errors.cc @librelois