Access StorageData for eth_getBalance #43
Conversation
|
Still TODO the support for all In this PR I just adapted the previously supported |
rpc/src/lib.rs
Outdated
| return Ok( | ||
| self.client | ||
| .runtime_api() | ||
| .account_decode(&BlockId::Hash(header.hash()), data.0) |
There was a problem hiding this comment.
If we are reading the raw account data, what's the reason still calling into runtime?
There was a problem hiding this comment.
Not adding the pallet-evm as a dependency for accessing the EvmAccount (as it's a dependency for the Runtime anyways).
If we are OK adding that dep, then it would make no sense of course.
There was a problem hiding this comment.
Also as a side note, Decode::decode cannot infer the data type, in this case pallet-evm::Account needs to be declared as the result type.
There was a problem hiding this comment.
The round trip call to runtime API is the main consumption of performance. If we still call in runtime I'm not sure how this PR brings improvements, TBH.
There was a problem hiding this comment.
Indeed. As in the RPC module we already have the frontier-rpc-primitives dep, we could do a public re-export of the pallet-evm::Account from there, and avoid calling the Runtime doing that. Let me update the PR with that.
|
As talked with @sorpaas, we probably are good just calling the Runtime Api impls passing the past BlockId as an argument. It is less efficient but way more easy to implement and it just fulfills our requirements. Closing. |
rel #7
eth_getBalanceStorageKeyforEVM::Accounts.client.storageto accessEVM::Accountsfor a givenBlockId.account_decodefor Runtime API toDecodeStorageData back topallet-evm::Accounttype.