Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials to latest monthly tag #607

Merged
merged 14 commits into from
Nov 30, 2021
Merged

Update tutorials to latest monthly tag #607

merged 14 commits into from
Nov 30, 2021

Conversation

sacha-l
Copy link

@sacha-l sacha-l commented Nov 24, 2021

Closes #606 (as well as other items in #132). This also implies closing this tracking issue.

The reason I used a separate tracking issue was because the work here updates the tutorial write-ups with relevant latest Substrate updates. #600 helped me keep track of both the "docs" work and the "template update" work which I did synchronously. For the docs stuff here, updates included:

  • Updating all git clone commands to clone the node template and checkout at latest
  • Removing the need to specify custom types in Polkadot JS Apps UI
  • Updating according to new pallet declaration in construct_runtime!
  • No longer needing to specify --tmp when launching a chain

I've compiled and tested all solutions and tutorial instructions accordingly. ✅

Once this updates and we figure out #588, all we'll have to do is find-and-replace monthly-2021-11-1 with latest throughout our docs and node template solutions.

cc: @nukemandan

@sacha-l sacha-l temporarily deployed to test November 24, 2021 16:39 Inactive
@sacha-l sacha-l linked an issue Nov 24, 2021 that may be closed by this pull request
6 tasks
@sacha-l sacha-l temporarily deployed to test November 24, 2021 16:44 Inactive
Copy link
Contributor

@lisa-parity lisa-parity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.
I'd also recommend using lower case for node template and front-end template.

Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@sacha-l sacha-l temporarily deployed to test November 24, 2021 22:37 Inactive
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
@sacha-l sacha-l temporarily deployed to test November 24, 2021 22:41 Inactive
@sacha-l sacha-l requested a review from lisa-parity November 24, 2021 22:41
@sacha-l sacha-l temporarily deployed to test November 24, 2021 22:47 Inactive
@sacha-l sacha-l mentioned this pull request Nov 25, 2021
2 tasks
Copy link
Contributor

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use of the latest tag should be propagated throughout.

@nuke-web3
Copy link
Contributor

nuke-web3 commented Nov 26, 2021

will this close #132 ? if only parts, can we check the items done as done once this lands?

@nuke-web3
Copy link
Contributor

nuke-web3 commented Nov 26, 2021

A few suggestions.
I'd also recommend using lower case for node template and front-end

@lisa-parity this is the opposite convention used before as these are proper nouns referring to not just any template(s) but our specific ones maintained in this github org. Did I miss this change in the style guide? In any case we should open an issue or PR if simpler to fix all instances on here and the sandbox.

@lsgunnlsgunn
Copy link
Contributor

We should always minimize the use of capitalization because it overuse of capitalization reduces readability. Common words should not be capitalized just because they are used in the context of a product description. Node template and front-end template are not proper nouns of the same category as Substrate (proper noun).

@sacha-l
Copy link
Author

sacha-l commented Nov 29, 2021

will this close #132 ? if only parts, can we check the items done as done once this lands?

That's the goal 😉

Co-authored-by: Lisa Gunn <44206363+lsgunnlsgunn@users.noreply.github.com>
@sacha-l sacha-l temporarily deployed to test November 30, 2021 17:55 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:01 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:09 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:16 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:19 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:42 Inactive
@sacha-l sacha-l temporarily deployed to test November 30, 2021 18:47 Inactive
add note solutions for diff and checkout to use
@nuke-web3 nuke-web3 temporarily deployed to test November 30, 2021 19:25 Inactive
Copy link
Contributor

@nuke-web3 nuke-web3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it LGTM! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants