-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tutorials to latest monthly tag #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions.
I'd also recommend using lower case for node template and front-end template.
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
Co-authored-by: lisa-parity <92225469+lisa-parity@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of the latest
tag should be propagated throughout.
will this close #132 ? if only parts, can we check the items done as done once this lands? |
@lisa-parity this is the opposite convention used before as these are proper nouns referring to not just any template(s) but our specific ones maintained in this github org. Did I miss this change in the style guide? In any case we should open an issue or PR if simpler to fix all instances on here and the sandbox. |
We should always minimize the use of capitalization because it overuse of capitalization reduces readability. Common words should not be capitalized just because they are used in the context of a product description. Node template and front-end template are not proper nouns of the same category as Substrate (proper noun). |
That's the goal 😉 |
Co-authored-by: Lisa Gunn <44206363+lsgunnlsgunn@users.noreply.github.com>
add note solutions for diff and checkout to use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it LGTM! 🎉
Closes #606 (as well as other items in #132). This also implies closing this tracking issue.
The reason I used a separate tracking issue was because the work here updates the tutorial write-ups with relevant latest Substrate updates. #600 helped me keep track of both the "docs" work and the "template update" work which I did synchronously. For the docs stuff here, updates included:
git clone
commands to clone the node template and checkout atlatest
construct_runtime!
--tmp
when launching a chainI've compiled and tested all solutions and tutorial instructions accordingly. ✅
Once this updates and we figure out #588, all we'll have to do is find-and-replace
monthly-2021-11-1
withlatest
throughout our docs and node template solutions.cc: @nukemandan