Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx pool style and copy updates #448

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Tx pool style and copy updates #448

merged 4 commits into from
Nov 8, 2021

Conversation

nuke-web3
Copy link
Contributor

tweaks to style, very minor copy edit.
uses "1 idea, one line" convention over the 100 char limit.

tweaks to style, very minor copy edit
@nuke-web3 nuke-web3 changed the title tweaks to style, very minor copy edit tx pool tweaks to style, very minor copy edit Oct 29, 2021
@sacha-l
Copy link

sacha-l commented Oct 29, 2021

@imadarai: is the build error coming from the "###" heading ? See error snip:

ERROR #95313

Building static HTML failed for path "/v3/concepts/tx-pool/"

See our docs page for more info on this error: https://gatsby.dev/debug-html



  61 |                     <div
  62 |                       className={`mb-2 hover:text-substrateBlue
dark:hover:text-substrateBlue-light ${
> 63 |                         activeHash === value.url.substr(1) &&
     |                                                  ^
  64 |                         'text-substrateBlue
dark:text-substrateBlue-light'
  65 |                       }`}
  66 |                     >


  WebpackError:TypeError: Cannot read property 'substr' of undefined

@nuke-web3
Copy link
Contributor Author

I would bet so: I did this on the github editor, and there is no h2 heading preceding. This is the intended behavior BTW, I want. the title is an h1, I don't want an h2 to start in this specific case, I wan to use a h3

@imadarai
Copy link

imadarai commented Oct 29, 2021

We've come across this before and the decision was made to force a h2 before h3 always as it breaks the ToC (Table of Content) design and it looks a bit wonky
Screenshot 2021-10-29 at 15 58 50

I would rather not change this convention, unless we are really in a big pickle 😶

EDIT:
#452 isn't really a bug, the check is in place on purpose to it doesn't break the design

@sacha-l
Copy link

sacha-l commented Oct 29, 2021

I think I can understand where you're coming from but this would be a good opportunity to align on putting our style guide to practice. This "h3" convention doesn't match up the rest of the guides so I would lean towards consistency with the others. Thoughts on this one @lsgunnlsgunn 😃 ? Perhaps we can improve how these guidelines are articulated here..

@lsgunnlsgunn
Copy link
Contributor

lsgunnlsgunn commented Oct 30, 2021

Having a h3 follow h1 breaks a fundamental rule. Please don't do this. If you think you have a legitimate rationale for breaking this rule, please explain what it is. (If you just don't like the size of h2 or something, let's put that in the list of visual elements we might want to revisit.) In most cases, most of your headings should be h2 level heads.

@sacha-l sacha-l temporarily deployed to test November 8, 2021 16:06 Inactive
@sacha-l sacha-l self-assigned this Nov 8, 2021
@sacha-l sacha-l temporarily deployed to test November 8, 2021 16:12 Inactive
@sacha-l sacha-l changed the title tx pool tweaks to style, very minor copy edit Tx pool updates Nov 8, 2021
@sacha-l sacha-l linked an issue Nov 8, 2021 that may be closed by this pull request
@sacha-l sacha-l changed the title Tx pool updates Tx pool style and copy updates Nov 8, 2021
@sacha-l sacha-l merged commit cbdc52d into main Nov 8, 2021
@sacha-l sacha-l deleted the NukeManDan-patch-1 branch November 8, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants