Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io] Chain Specification #27

Merged
merged 35 commits into from
Nov 12, 2024
Merged

[Substrate.io] Chain Specification #27

merged 35 commits into from
Nov 12, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

The "Chain Specification" page was migrated from Substrate.io: https://docs.substrate.io/build/chain-spec/

@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 16, 2024
@eshaben eshaben requested review from nhussein11 and 0xLucca October 1, 2024 18:58
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
develop/parachain-devs/parachain-launch/chain-spec.md Outdated Show resolved Hide resolved
@nhussein11
Copy link
Collaborator

Disclaimer - I'm taking over this PR and will move it to the "Generate Chain Specs and WASM" page under the Deployment section of the new IA

nhussein11 and others added 7 commits November 4, 2024 09:31
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Co-authored-by: 0xLucca <95830307+0xLucca@users.noreply.github.com>
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@0xLucca 0xLucca requested review from a team and removed request for michalkucharczyk November 7, 2024 10:24
themacexpert and others added 9 commits November 8, 2024 10:43
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
Copy link
Contributor

@michalkucharczyk michalkucharczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link that was used here is a in-depth guide, and for sure it is worth keeping it:
https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/reference_docs/chain_spec_genesis/index.html

Would be great to see a reference to this link. I think it may be valuable.

@themacexpert
Copy link
Collaborator

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some minor formatting stuff

develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
develop/blockchains/deployment/generate-chain-specs.md Outdated Show resolved Hide resolved
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@dawnkelly09 dawnkelly09 requested a review from eshaben November 11, 2024 20:24
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit df95445 into master Nov 12, 2024
@eshaben eshaben deleted the bd-chain-spec branch November 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants