Custom Blockchains > Benchmarking

[CrackTheCode016]

Adds the Benchmarking page, which is based on:

• https://docs.substrate.io/reference/how-to-guides/weights/add-benchmarks/
• https://docs.substrate.io/test/benchmark/
• https://paritytech.github.io/polkadot-sdk/master/frame_benchmarking/v2/index.html

Only relevant content was ported, the rest was written to reflect the latest in benchmarking.

[CrackTheCode016]

@nhussein11 @0xLucca Added some barebones content here, could you take a look and see what is missing / what is unclear? Thanks!

Approved by error

[kianenigma]

I have very recently added a new reference doc on this:

https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/reference_docs/frame_benchmarking_weight/index.html

it is very short, but covers the fundamentals pretty well.

[CrackTheCode016]

@kianenigma Oh perfect, I have not used the omni_bencher yet, do you think it is ready to be implemented as the primary method here?

[CrackTheCode016]

I spent some time with frame-omni-benchmark - it seems like it needs a little more time before including it in a doc like this, namely ensuring it works with templates (right now, the blocker is having naturally occuring presets in a template, see: paritytech/polkadot-sdk-parachain-template#19)

For now, will stick to the "old" approach. It will not take much to replace with omni-bencher once everything is synced up.

Edit: we should make a note for a follow up PR as per this: paritytech/polkadot-sdk-parachain-template#19 (comment) cc @kapetan3sid

[kianenigma]

@kianenigma Oh perfect, I have not used the omni_bencher yet, do you think it is ready to be implemented as the primary method here?

One major PR is missing before it can reach feature parity with the old one: paritytech/polkadot-sdk#5303

But for 99% of the teams, it is already enough; and it is more future proof.

[nhussein11]

LGTM besides those small details! thank you!!

[kianenigma]

https://paritytech.github.io/polkadot-sdk/master/frame_benchmarking/macro.define_benchmarks.html

Is this good enough? can you contribute back anything to this?

[CrackTheCode016]

Maybe an example + slightly clearer description of what that looks like syntactically to better illustrate what is going on, I can open a PR and do this if wanted

[dawnkelly09]

@polkadot-developers/docs-content-team: I did some formatting and grammar work on this page. Two asks:

1. Please take a quick look and make sure this is all still accurate, etc.
2. Please let me know if all the discussions/decisions in the convos are resolved so we know if content is done with this and we can merge once we're happy with styling/grammar stuff
   Thank you!

[dawnkelly09]

Made grammar and formatting updates. Needs approval from content and then final look from Erin or another formatting/grammar reviewer

[eshaben]

Looks good! Just some minor formatting things 🙂

[eshaben]

LGTM!