feat(script editor): add opt out language warning #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@politics-rewired/organizing for copy review |
hiemanshu
approved these changes
Sep 26, 2022
bchrobot
reviewed
Sep 26, 2022
src/components/ScriptEditor.tsx
Outdated
| .toLowerCase(); | ||
|
|
||
| // 2022-09-24 - stop as a separate word is best for avoiding spam blocks | ||
| if (this.props.isRootStep && text.length > 0 && !text.includes(" stop ")) |
There was a problem hiding this comment.
Question: should this be "stop " with only a trailing space? I'm imagining the cases of newlines or parentheses:
Hey {firstName}, do you prefer apples or oranges?
STOP to quit
or
Hey {firstName}! (STOP to quit)
src/components/ScriptEditor.tsx
Outdated
| @@ -320,6 +321,34 @@ class ScriptEditor extends React.Component<Props, State> { | |||
| } | |||
| } | |||
|
|
|||
| renderOptOutLanguageWarning() { | |||
| const text = this.state.editorState | |||
There was a problem hiding this comment.
Suggestion: rename for context when scanning quickly
Suggested change
| const text = this.state.editorState | |
| const lowercaseText = this.state.editorState |
|
Per organizing team feedback, we're going to move this warning into a dialog to be extra sure users see it - in a PR coming soon |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a warning for including opt out language when users are editing initial messages.
Motivation and Context
Closes #1433
How Has This Been Tested?
This has been tested locally.
Screenshots (if appropriate):
Documentation Changes
Checklist: